Re: [PATCH 04/21] sh: select legacy gpiolib interface

["Arnd Bergmann" <arnd@arndb.de>]

On Tue, Aug 12, 2025, at 20:28, Rob Landley wrote:
> On 8/8/25 10:17, Arnd Bergmann wrote:
>> diff --git a/arch/sh/Kconfig b/arch/sh/Kconfig
>> index d5795067befa..d60f1d5a94c0 100644
>> --- a/arch/sh/Kconfig
>> +++ b/arch/sh/Kconfig
>> @@ -462,6 +462,7 @@ config CPU_SUBTYPE_SHX3
>>   	select CPU_SHX3
>>   	select GENERIC_CLOCKEVENTS_BROADCAST if SMP
>>   	select GPIOLIB
>> +	select GPIOLIB_LEGACY
>>   	select PINCTRL
>
> Is there a reason to have both rather than having GPIOLIB_LEGACY select 
> GPIOLIB? (Does the legacy one ever NOT use the new one?)

The way I've staged the series was

1. add GPIOLIB_LEGACY as an always-enabled symbol in 6.17
2. add the 'select' and 'depends on' for that symbol in 6.18
3. turn it off for all configs that don't select it already

Having GPIOLIB_LEGACY select GPIOLIB does sound like a nice
idea in stage 3, but that doesn't work with the first step
that's already merged now.

      Arnd