From: Andrew Lunn <andrew@lunn.ch>
To: Alex Tran <alex.t.tran@gmail.com>
Cc: alex@digriz.org.uk, sebastian.hesselbarth@gmail.com,
gregory.clement@bootlin.com, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] arm: mach-orion5x: ts78xx: simplify support configuration with table
Date: Mon, 13 Oct 2025 14:14:27 +0200 [thread overview]
Message-ID: <e729b553-98bd-440d-a0e7-bd84448bd9d8@lunn.ch> (raw)
In-Reply-To: <20251012235147.325532-1-alex.t.tran@gmail.com>
On Sun, Oct 12, 2025 at 04:51:47PM -0700, Alex Tran wrote:
> Replace switch statement based configuration with a lookup table approach.
> The table is iterated through matching the correct configuration instead of
> setting the configuration on a case by case basis.
Is there anything actually wrong with the current code?
How did you test this? Do you have a tx78xx?
The only changes made to this file in the last decade have been tree
wide changes. So unless you have one of these machines and intend to
add new features, i suggest you just leave this alone, it is just
needles churn to an ancient platform.
Andrew
prev parent reply other threads:[~2025-10-13 12:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-12 23:51 Alex Tran
2025-10-13 12:14 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e729b553-98bd-440d-a0e7-bd84448bd9d8@lunn.ch \
--to=andrew@lunn.ch \
--cc=alex.t.tran@gmail.com \
--cc=alex@digriz.org.uk \
--cc=gregory.clement@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®