Re: [PATCH v3 1/7] HID: asus: Fix up Zenbook Duo report descriptors

[Denis Benato <denis.benato@linux.dev>]

On 10/18/26 18:18, Rebecca Mara Müller wrote:
> On Sun, Oct 18, 2026 at 05:50:08PM +0200, Denis Benato wrote:
>> Does the zenbook duo really needs fixing the report descriptor? I think you can avoid this
>> altogether on this hardware.
> Welcome back, Denis. I tested exactly that on my UX8407AA today, docked
> over USB: v3 built as an out-of-tree module against a 7.0.11-based
> distribution kernel, once as posted and once with only the Zenbook Duo
> fixup disabled (QUIRK_ZENBOOK_DUO_KEYBOARD removed from the fixup
> condition, nothing else changed), my userspace workaround stopped.

Thank you Rebecca!

> Without the fixup, the hotkey interface gets no input device at all:
>
>   asus 0003:0B05:1CD7.000A: hiddev2,hidraw8: USB HID v1.11 Device [...] on usb-0000:00:14.0-6/input4
>
> With the fixup:
>
>   asus 0003:0B05:1CD7.000A: Fixing up Zenbook Duo keyb report descriptor
>   asus 0003:0B05:1CD7.000A: input,hiddev2,hidraw8: USB HID v1.11 Device [...] on usb-0000:00:14.0-6/input4
>
> Without the fixup, volume up/down and mute still work, as they come from
> another interface, but screen brightness, keyboard backlight, mic mute
> and Fn+F profile cycling are dead (checked with an evdev reader and
> /sys/firmware/acpi/platform_profile). With the fixup all of them work.
> So yes, as far as I can tell this keyboard needs it.

Okay... Noted. Is the forcing of a name required too? It has caused a debate
in the past, we used to rename all input devices on hid-asus and now we
don't anymore so if can be avoided it would be great to follow the now
preferred way.

> On the Assisted-by format: my original patch (7/7) was written with
> Claude Code using claude-fable-5, so following
> Documentation/process/coding-assistants.rst that would be
>
> Assisted-by: Claude:claude-fable-5
>
> Paolo, feel free to use that above my Signed-off-by in a respin.
>
> Thanks,
> Rebecca

Thanks for your time and effort,
Denis