From: Josh Law <hlcj1234567@gmail.com>
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Josh Law <objecting@objecting.org>
Subject: Re: [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean
Date: Mon, 2 Mar 2026 07:11:43 +0000 [thread overview]
Message-ID: <e73c87c3-a233-4c47-b971-0befb0ab326f@gmail.com> (raw)
In-Reply-To: <aaT94cjUleIyvJ_u@google.com>
>>
>> checkpath.pl reported the following warnings:
>>
>> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
>> #81:
>> Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools.
>>
>> WARNING: From:/Signed-off-by: email address mismatch: 'From: Josh Law <hlcj1234567@gmail.com>' != 'Signed-off-by: Josh Law <objecting@objecting.org>'
>>
>> total: 0 errors, 2 warnings, 0 checks, 9 lines checked
>>
>
> BTW, both of your patches does not apply cleanly.
>
> Regards,
> Kuan-Wei
I think Andrew fixed that....
Including the from lines
V/R
prev parent reply other threads:[~2026-03-02 7:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 15:21 [PATCH 1/2] lib: glob: add explicit include for export.h Josh Law
2026-03-01 15:21 ` [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean Josh Law
2026-03-01 19:25 ` Andrew Morton
2026-03-01 19:40 ` Josh Law
2026-03-01 19:43 ` Andrew Morton
2026-03-01 22:05 ` David Laight
2026-03-02 2:56 ` Kuan-Wei Chiu
2026-03-02 3:02 ` Kuan-Wei Chiu
2026-03-02 7:11 ` Josh Law [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e73c87c3-a233-4c47-b971-0befb0ab326f@gmail.com \
--to=hlcj1234567@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=objecting@objecting.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®