From: "Christian König" <christian.koenig@amd.com>
To: Baoyou Xie <baoyou.xie@linaro.org>, <alexander.deucher@amd.com>,
<airlied@linux.ie>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<arnd@arndb.de>, <xie.baoyou@zte.com.cn>, <han.fei@zte.com.cn>,
<tang.qiang007@zte.com.cn>
Subject: Re: [PATCH 1/3] drm/radeon: add missing header dependencies
Date: Fri, 30 Sep 2016 13:52:35 +0200 [thread overview]
Message-ID: <e7567fa0-d966-16db-123f-bf9a480acdc3@amd.com> (raw)
In-Reply-To: <1475223183-19698-1-git-send-email-baoyou.xie@linaro.org>
This one and patch #3 are Reviewed-by: Christian König
<christian.koenig@amd.com>.
Where is patch #2? That never made it into my inbox.
Regards,
Christian.
Am 30.09.2016 um 10:13 schrieb Baoyou Xie:
> We get a few warnings when building kernel with W=1:
> drivers/gpu/drm/radeon/radeon_clocks.c:35:10: warning: no previous prototype for 'radeon_legacy_get_engine_clock' [-Wmissing-prototypes]
> drivers/gpu/drm/radeon/atombios_encoders.c:75:1: warning: no previous prototype for 'atombios_get_backlight_level' [-Wmissing-prototypes]
> drivers/gpu/drm/radeon/r600_cs.c:2268:5: warning: no previous prototype for 'r600_cs_parse' [-Wmissing-prototypes]
> drivers/gpu/drm/radeon/evergreen_cs.c:2671:5: warning: no previous prototype for 'evergreen_cs_parse' [-Wmissing-prototypes]
> ....
>
> In fact, these functions are declared
> in drivers/gpu/drm/radeon/radeon_asic.h,
> so this patch adds missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/gpu/drm/radeon/atombios_encoders.c | 1 +
> drivers/gpu/drm/radeon/evergreen_cs.c | 1 +
> drivers/gpu/drm/radeon/r600_cs.c | 1 +
> drivers/gpu/drm/radeon/radeon_atombios.c | 1 +
> drivers/gpu/drm/radeon/radeon_clocks.c | 1 +
> drivers/gpu/drm/radeon/radeon_legacy_encoders.c | 1 +
> 6 files changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/radeon/atombios_encoders.c b/drivers/gpu/drm/radeon/atombios_encoders.c
> index 56bb758..fa4f8f0 100644
> --- a/drivers/gpu/drm/radeon/atombios_encoders.c
> +++ b/drivers/gpu/drm/radeon/atombios_encoders.c
> @@ -28,6 +28,7 @@
> #include <drm/radeon_drm.h>
> #include "radeon.h"
> #include "radeon_audio.h"
> +#include "radeon_asic.h"
> #include "atom.h"
> #include <linux/backlight.h>
>
> diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
> index d960d39..f8b0509 100644
> --- a/drivers/gpu/drm/radeon/evergreen_cs.c
> +++ b/drivers/gpu/drm/radeon/evergreen_cs.c
> @@ -27,6 +27,7 @@
> */
> #include <drm/drmP.h>
> #include "radeon.h"
> +#include "radeon_asic.h"
> #include "evergreend.h"
> #include "evergreen_reg_safe.h"
> #include "cayman_reg_safe.h"
> diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c
> index b69c8de..595a197 100644
> --- a/drivers/gpu/drm/radeon/r600_cs.c
> +++ b/drivers/gpu/drm/radeon/r600_cs.c
> @@ -28,6 +28,7 @@
> #include <linux/kernel.h>
> #include <drm/drmP.h>
> #include "radeon.h"
> +#include "radeon_asic.h"
> #include "r600d.h"
> #include "r600_reg_safe.h"
>
> diff --git a/drivers/gpu/drm/radeon/radeon_atombios.c b/drivers/gpu/drm/radeon/radeon_atombios.c
> index 5df3ec7..4134759 100644
> --- a/drivers/gpu/drm/radeon/radeon_atombios.c
> +++ b/drivers/gpu/drm/radeon/radeon_atombios.c
> @@ -29,6 +29,7 @@
>
> #include "atom.h"
> #include "atom-bits.h"
> +#include "radeon_asic.h"
>
> extern void
> radeon_add_atom_encoder(struct drm_device *dev, uint32_t encoder_enum,
> diff --git a/drivers/gpu/drm/radeon/radeon_clocks.c b/drivers/gpu/drm/radeon/radeon_clocks.c
> index 38e396d..c1135fe 100644
> --- a/drivers/gpu/drm/radeon/radeon_clocks.c
> +++ b/drivers/gpu/drm/radeon/radeon_clocks.c
> @@ -29,6 +29,7 @@
> #include <drm/radeon_drm.h>
> #include "radeon_reg.h"
> #include "radeon.h"
> +#include "radeon_asic.h"
> #include "atom.h"
>
> /* 10 khz */
> diff --git a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> index 868c3ba..222a1fa 100644
> --- a/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> +++ b/drivers/gpu/drm/radeon/radeon_legacy_encoders.c
> @@ -27,6 +27,7 @@
> #include <drm/drm_crtc_helper.h>
> #include <drm/radeon_drm.h>
> #include "radeon.h"
> +#include "radeon_asic.h"
> #include "atom.h"
> #include <linux/backlight.h>
> #ifdef CONFIG_PMAC_BACKLIGHT
next prev parent reply other threads:[~2016-09-30 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 8:13 Baoyou Xie
2016-09-30 8:13 ` [PATCH 3/3] drm/radeon: mark symbols static where possible Baoyou Xie
2016-09-30 8:13 ` Baoyou Xie
2016-09-30 11:52 ` Christian König [this message]
2016-09-30 17:26 ` [PATCH 1/3] drm/radeon: add missing header dependencies Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7567fa0-d966-16db-123f-bf9a480acdc3@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=han.fei@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=tang.qiang007@zte.com.cn \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®