mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] gpio: loongson-64bit: Fix NULL check after devm_kcalloc() in loongson_gpio_init_irqchip()
@ 2026-02-05  7:26 Chen Ni
  2026-02-05 12:46 ` Markus Elfring
  2026-02-05 17:01 ` Bartosz Golaszewski
  0 siblings, 2 replies; 3+ messages in thread
From: Chen Ni @ 2026-02-05  7:26 UTC (permalink / raw)
  To: zhuyinbo, linusw, brgl, ziyao, chenhuacai
  Cc: linux-gpio, linux-kernel, Chen Ni

Fix incorrect NULL check in loongson_gpio_init_irqchip().
The function checks chip->parent instead of chip->irq.parents.

Fixes: 03c146cb6cd1 ("gpio: loongson-64bit: Add support for Loongson-2K0300 SoC")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
---
 drivers/gpio/gpio-loongson-64bit.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-loongson-64bit.c b/drivers/gpio/gpio-loongson-64bit.c
index 77d07e31366f..0fdf15faa344 100644
--- a/drivers/gpio/gpio-loongson-64bit.c
+++ b/drivers/gpio/gpio-loongson-64bit.c
@@ -263,7 +263,7 @@ static int loongson_gpio_init_irqchip(struct platform_device *pdev,
 	chip->irq.num_parents = data->intr_num;
 	chip->irq.parents = devm_kcalloc(&pdev->dev, data->intr_num,
 					 sizeof(*chip->irq.parents), GFP_KERNEL);
-	if (!chip->parent)
+	if (!chip->irq.parents)
 		return -ENOMEM;
 
 	for (i = 0; i < data->intr_num; i++) {
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gpio: loongson-64bit: Fix NULL check after devm_kcalloc() in loongson_gpio_init_irqchip()
  2026-02-05  7:26 [PATCH] gpio: loongson-64bit: Fix NULL check after devm_kcalloc() in loongson_gpio_init_irqchip() Chen Ni
@ 2026-02-05 12:46 ` Markus Elfring
  2026-02-05 17:01 ` Bartosz Golaszewski
  1 sibling, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2026-02-05 12:46 UTC (permalink / raw)
  To: Chen Ni, linux-gpio, Bartosz Golaszewski, Huacai Chen,
	Linus Walleij, Yao Zi, Yinbo Zhu
  Cc: LKML

> Fix incorrect NULL check in loongson_gpio_init_irqchip().
…

* Were any source code analysis tools involved here?

* See also once more:
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/stable-kernel-rules.rst?h=v6.19-rc8#n34


Regards,
Markus

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] gpio: loongson-64bit: Fix NULL check after devm_kcalloc() in loongson_gpio_init_irqchip()
  2026-02-05  7:26 [PATCH] gpio: loongson-64bit: Fix NULL check after devm_kcalloc() in loongson_gpio_init_irqchip() Chen Ni
  2026-02-05 12:46 ` Markus Elfring
@ 2026-02-05 17:01 ` Bartosz Golaszewski
  1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2026-02-05 17:01 UTC (permalink / raw)
  To: zhuyinbo, linusw, brgl, ziyao, chenhuacai, Chen Ni
  Cc: Bartosz Golaszewski, linux-gpio, linux-kernel


On Thu, 05 Feb 2026 15:26:49 +0800, Chen Ni wrote:
> Fix incorrect NULL check in loongson_gpio_init_irqchip().
> The function checks chip->parent instead of chip->irq.parents.
> 
> 

Applied, thanks!

[1/1] gpio: loongson-64bit: Fix NULL check after devm_kcalloc() in loongson_gpio_init_irqchip()
      https://git.kernel.org/brgl/c/e34f77b09080c86c929153e2a72da26b4f8947ff

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-02-05 17:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-05  7:26 [PATCH] gpio: loongson-64bit: Fix NULL check after devm_kcalloc() in loongson_gpio_init_irqchip() Chen Ni
2026-02-05 12:46 ` Markus Elfring
2026-02-05 17:01 ` Bartosz Golaszewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®