mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Conor Dooley" <conor@kernel.org>,
	"Julian Braha" <julianbraha@gmail.com>
Cc: "Bin Liu" <b-liu@ti.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Conor.Dooley" <conor.dooley@microchip.com>,
	"Daire McNamara" <daire.mcnamara@microchip.com>,
	valentina.fernandezalanis@microchip.com,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Stephen Boyd" <sboyd@kernel.org>,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>,
	"Jassi Brar" <jassisinghbrar@gmail.com>,
	"Alessandro Zummo" <a.zummo@towertech.it>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Wolfram Sang" <wsa@kernel.org>,
	"Ben Dooks" <ben.dooks@codethink.co.uk>,
	"Heinrich Schuchardt" <heinrich.schuchardt@canonical.com>
Subject: Re: [PATCH] usb: musb: fix dead select of USB_MUSB_DUAL_ROLE
Date: Mon, 13 Jul 2026 08:26:46 +0200	[thread overview]
Message-ID: <e771f4d0-a442-4a02-9ea8-4d6078d74bd8@app.fastmail.com> (raw)
In-Reply-To: <20260712-parole-stoning-d7e66a0961a8@spud>

On Sun, Jul 12, 2026, at 23:56, Conor Dooley wrote:
> On Sat, Jul 11, 2026 at 04:09:58PM +0100, Julian Braha wrote:
>> On 7/11/26 15:39, Arnd Bergmann wrote:
>> > Good catch, but I wonder if this is actually a real dependency
>> > at all. What would happen if you just remove the 'select' line
>> > here and build a polarfire kernel that only supports
>> > host or gadget mode but not dual-role?
>> 
>> The kernel builds just fine for me with USB_MUSB_POLARFIRE_SOC=y and
>> USB_MUSB_DUAL_ROLE=n
>> 
> This is the setup I've been using in my development environment for
> (probably) years.
>
> Probably the select should just be deleted.

Ok, so it was probably just a misguided attempt to pick the most
useful configuration by default.

Julian, can you send a new patch to just drop the line?

        Arnd

      reply	other threads:[~2026-07-13  6:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-11 13:03 Julian Braha
2026-07-11 14:39 ` Arnd Bergmann
2026-07-11 15:09   ` Julian Braha
2026-07-12 21:56     ` Conor Dooley
2026-07-13  6:26       ` Arnd Bergmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e771f4d0-a442-4a02-9ea8-4d6078d74bd8@app.fastmail.com \
    --to=arnd@arndb.de \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=b-liu@ti.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=claudiu.beznea@microchip.com \
    --cc=conor.dooley@microchip.com \
    --cc=conor@kernel.org \
    --cc=daire.mcnamara@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heinrich.schuchardt@canonical.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=julianbraha@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@kernel.org \
    --cc=valentina.fernandezalanis@microchip.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®