From: "Arnd Bergmann" <arnd@arndb.de>
To: "Julian Braha" <julianbraha@gmail.com>, "Bin Liu" <b-liu@ti.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: musb: fix dead select of USB_MUSB_DUAL_ROLE
Date: Sat, 11 Jul 2026 16:39:06 +0200 [thread overview]
Message-ID: <f4ef4d30-51de-4b58-807a-0fed243b2fe4@app.fastmail.com> (raw)
In-Reply-To: <20260711130349.592545-1-julianbraha@gmail.com>
On Sat, Jul 11, 2026, at 15:03, Julian Braha wrote:
> 'select' does not work on config options in a 'choice', so currently it is
> possible to enable USB_MUSB_POLARFIRE_SOC without USB_MUSB_DUAL_ROLE.
>
> Replace 'select' with 'depends on'.
>
> This dead select was found by kconfirm, a static analysis tool for Kconfig.
>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>
Good catch, but I wonder if this is actually a real dependency
at all. What would happen if you just remove the 'select' line
here and build a polarfire kernel that only supports
host or gadget mode but not dual-role?
Arnd
next prev parent reply other threads:[~2026-07-11 14:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-11 13:03 Julian Braha
2026-07-11 14:39 ` Arnd Bergmann [this message]
2026-07-11 15:09 ` Julian Braha
2026-07-12 21:56 ` Conor Dooley
2026-07-13 6:26 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4ef4d30-51de-4b58-807a-0fed243b2fe4@app.fastmail.com \
--to=arnd@arndb.de \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=julianbraha@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome