From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFT PATCH 06/14] arm64: dts: qcom: sc7180: add missing TCSR syscon compatible
Date: Wed, 17 Aug 2022 15:38:51 +0300 [thread overview]
Message-ID: <e7c29e37-3ff8-775f-292f-a87e419ac3ee@linaro.org> (raw)
In-Reply-To: <20220817120403.458000-8-krzysztof.kozlowski@linaro.org>
On 17/08/2022 15:03, Krzysztof Kozlowski wrote:
> TCSR syscon node should come with dedicated compatible.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index b82c335c25af..49f28cb531f6 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1468,7 +1468,7 @@ tcsr_mutex_regs: syscon@1f40000 {
> };
>
> tcsr_regs: syscon@1fc0000 {
> - compatible = "syscon";
> + compatible = "qcom,sc7180-tcsr", "syscon";
Compatible is wrong here. I will send a v2 tomorrow.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-17 12:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 12:03 [RFT PATCH 00/14] arm64: dts: qcom: improvements to TCSR mutex in DTS Krzysztof Kozlowski
2022-08-17 12:03 ` [RFT PATCH 01/14] dt-bindings: mfd: qcom,tcsr: add SC7180, SC7280, SDM845 and MSM8998 Krzysztof Kozlowski
2022-08-17 12:03 ` [RFT PATCH 01/14] dt-bindings: mfd: qcom,tcsr: add SC7x80, SDM845 and MSM8996/8 Krzysztof Kozlowski
2022-08-17 12:03 ` [RFT PATCH 02/14] arm64: dts: qcom: msm8996: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-08-17 12:03 ` [RFT PATCH 03/14] arm64: dts: qcom: msm8996: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 12:03 ` [RFT PATCH 04/14] arm64: dts: qcom: msm8998: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-08-17 12:03 ` [RFT PATCH 05/14] arm64: dts: qcom: msm8998: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 12:03 ` [RFT PATCH 06/14] arm64: dts: qcom: sc7180: add missing TCSR syscon compatible Krzysztof Kozlowski
2022-08-17 12:38 ` Krzysztof Kozlowski [this message]
2022-08-17 12:40 ` Krzysztof Kozlowski
2022-08-17 12:03 ` [RFT PATCH 07/14] arm64: dts: qcom: sc7180: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-08-17 12:03 ` [RFT PATCH 08/14] arm64: dts: qcom: sc7180: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 12:03 ` [RFT PATCH 09/14] arm64: dts: qcom: sc7280: split TCSR halt regs out of mutex Krzysztof Kozlowski
2022-08-17 12:03 ` [RFT PATCH 10/14] arm64: dts: qcom: sdm845: " Krzysztof Kozlowski
2022-08-17 12:04 ` [RFT PATCH 11/14] arm64: dts: qcom: sdm845: switch TCSR mutex to MMIO Krzysztof Kozlowski
2022-08-17 12:04 ` [RFT PATCH 12/14] arm64: dts: qcom: qcs404: " Krzysztof Kozlowski
2022-08-17 12:04 ` [RFT PATCH 13/14] arm64: dts: qcom: sdm630: " Krzysztof Kozlowski
2022-08-17 12:04 ` [RFT PATCH 14/14] arm64: dts: qcom: sm8150: " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e7c29e37-3ff8-775f-292f-a87e419ac3ee@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®