From: neil.armstrong@linaro.org
To: Jun Nie <jun.nie@linaro.org>, Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Vinod Koul <vkoul@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Jonathan Marek <jonathan@marek.ca>
Subject: Re: [PATCH v5 0/6] Add DSC support to DSI video panel
Date: Tue, 28 May 2024 09:56:48 +0200 [thread overview]
Message-ID: <e8268cf2-16e1-4903-9dc5-9377a9be7d0e@linaro.org> (raw)
In-Reply-To: <20240527-msm-drm-dsc-dsi-video-upstream-4-v5-0-f797ffba4682@linaro.org>
On 27/05/2024 16:21, Jun Nie wrote:
> This is follow up update to Jonathan's patch set.
>
> Changes vs V4:
> - Polish width calculation with helper function
> - Split cfg2 compression bit into another patch
>
> Changes vs V3:
> - Rebase to latest msm-next-lumag branch.
> - Drop the slice_per_pkt change as it does impact basic DSC feature.
> - Remove change in generated dsi header
> - update DSC compressed width calculation with bpp and bpc
> - split wide bus impact on width into another patch
> - rename patch tile of VIDEO_COMPRESSION_MODE_CTRL_WC change
> - Polish warning usage
> - Add tags from reviewers
>
> Changes vs V2:
> - Drop the INTF_CFG2_DATA_HCTL_EN change as it is handled in
> latest mainline code.
> - Drop the bonded DSI patch as I do not have device to test it.
> - Address comments from version 2.
>
> Signed-off-by: Jun Nie <jun.nie@linaro.org>
> ---
> Changes in v5:
> - Link to v4: https://lore.kernel.org/r/20240524-msm-drm-dsc-dsi-video-upstream-4-v4-0-e61c05b403df@linaro.org
>
> ---
> Jonathan Marek (4):
> drm/msm/dpu: fix video mode DSC for DSI
> drm/msm/dsi: set video mode widebus enable bit when widebus is enabled
> drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC
> drm/msm/dsi: add a comment to explain pkt_per_line encoding
>
> Jun Nie (2):
> drm/msm/dpu: adjust data width for widen bus case
> drm/msm/dpu: enable compression bit in cfg2 for DSC
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 8 ++++++++
> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 18 ++++++++++++++++++
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_intf.c | 13 +++++++++++++
> drivers/gpu/drm/msm/dsi/dsi_host.c | 10 +++++++++-
> 5 files changed, 49 insertions(+), 2 deletions(-)
> ---
> base-commit: e6428bcb611f6c164856a41fc5a1ae8471a9b5a9
> change-id: 20240524-msm-drm-dsc-dsi-video-upstream-4-22e2266fbe89
>
> Best regards,
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8550-QRD
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-QRD
Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK
with https://lore.kernel.org/all/20230728012623.22991-1-quic_parellan@quicinc.com/ and enforce-video-mode in panel node.
Thanks,
Neil
prev parent reply other threads:[~2024-05-28 7:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 14:21 Jun Nie
2024-05-27 14:21 ` [PATCH v5 1/6] drm/msm/dpu: fix video mode DSC for DSI Jun Nie
2024-05-28 0:45 ` Dmitry Baryshkov
2024-05-28 21:16 ` Jessica Zhang
2024-05-27 14:21 ` [PATCH v5 2/6] drm/msm/dpu: adjust data width for widen bus case Jun Nie
2024-05-28 0:48 ` Dmitry Baryshkov
2024-05-28 9:59 ` Jun Nie
2024-05-28 11:56 ` Dmitry Baryshkov
2024-05-28 23:07 ` Jessica Zhang
2024-05-27 14:21 ` [PATCH v5 3/6] drm/msm/dpu: enable compression bit in cfg2 for DSC Jun Nie
2024-05-28 0:48 ` Dmitry Baryshkov
2024-05-28 22:59 ` Jessica Zhang
2024-05-27 14:21 ` [PATCH v5 4/6] drm/msm/dsi: set video mode widebus enable bit when widebus is enabled Jun Nie
2024-05-27 14:21 ` [PATCH v5 5/6] drm/msm/dsi: set VIDEO_COMPRESSION_MODE_CTRL_WC Jun Nie
2024-05-28 22:12 ` Jessica Zhang
2024-05-27 14:21 ` [PATCH v5 6/6] drm/msm/dsi: add a comment to explain pkt_per_line encoding Jun Nie
2024-05-28 22:19 ` Jessica Zhang
2024-05-28 7:56 ` neil.armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8268cf2-16e1-4903-9dc5-9377a9be7d0e@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=jun.nie@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_jesszhan@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®