mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daisuke Matsuda <dskmtsd@gmail.com>
To: Xu Yilun <yilun.xu@linux.intel.com>
Cc: yilun.xu@intel.com, mdf@kernel.org, trix@redhat.com,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org,
	Daisuke Matsuda <matsuda@preferred.jp>
Subject: Re: [PATCH 2/2] fpga: altera-cvp: Propagate PCI config access errors
Date: Thu, 23 Jul 2026 16:00:18 +0900	[thread overview]
Message-ID: <e849a2b1-58b0-4423-81bf-ec833fa5ee83@gmail.com> (raw)
In-Reply-To: <amGNwqOFs3oLXhWt@yilunxu-OptiPlex-7050>

On 2026/07/23 12:42, Xu Yilun wrote:
> On Wed, Jul 01, 2026 at 09:26:33AM +0000, Daisuke Matsuda wrote:
>> From: Daisuke Matsuda <matsuda@preferred.jp>
>>
>> The CvP control path accesses the VSEC registers through PCI config space,
>> but several reads and writes ignore the return value. If a config read
>> fails, the driver can make decisions from an undefined register value and
>> continue programming with bogus status or control bits.
> 
> Searching from the kernel, most pci_read/write_config_dword() don't
> check return values. Could you help me understand why they don't but
> this driver has the specific need?

Hi Yilun,

Thank you for taking a look.

I agree that the vast majority of drivers do not check the return values, and I don't have a strong reason to make this driver behave differently.

I'll drop this patch and send a v2 with only patch 1/2.

Thanks,
Daisuke

> 
> Thanks,
> Yilun


  reply	other threads:[~2026-07-23  7:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-01  9:26 [PATCH 1/2] fpga: altera-cvp: Avoid out-of-bounds read in trailing byte write Daisuke Matsuda
2026-07-01  9:26 ` [PATCH 2/2] fpga: altera-cvp: Propagate PCI config access errors Daisuke Matsuda
2026-07-23  3:42   ` Xu Yilun
2026-07-23  7:00     ` Daisuke Matsuda [this message]
2026-07-23  3:44 ` [PATCH 1/2] fpga: altera-cvp: Avoid out-of-bounds read in trailing byte write Xu Yilun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e849a2b1-58b0-4423-81bf-ec833fa5ee83@gmail.com \
    --to=dskmtsd@gmail.com \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matsuda@preferred.jp \
    --cc=mdf@kernel.org \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    --cc=yilun.xu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®