From: Eddie James <eajames@linux.ibm.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Ninad Palsule <ninad@linux.ibm.com>,
linux-fsi@lists.ozlabs.org, Mark Brown <broonie@kernel.org>,
linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 13/13] spi: fsi: Convert to fsi bus probe mechanism
Date: Tue, 27 Jan 2026 09:29:52 -0600 [thread overview]
Message-ID: <e852b379-eb7b-4088-ad47-471ea1d755e2@linux.ibm.com> (raw)
In-Reply-To: <fc2a758ef00844dd5bd614a25b36a4a38355d12d.1765279318.git.u.kleine-koenig@baylibre.com>
On 12/9/25 5:40 AM, Uwe Kleine-König wrote:
> The fsi bus got a dedicated probe function. Make use of that. This fixes
> a runtime warning about the driver needing to be converted to the bus
> probe method.
Acked-by: Eddie James <eajames@linux.ibm.com>
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> Acked-by: Mark Brown <broonie@kernel.org>
> ---
> drivers/spi/spi-fsi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/spi-fsi.c b/drivers/spi/spi-fsi.c
> index f9c15b99dba5..07dc3d24f2c9 100644
> --- a/drivers/spi/spi-fsi.c
> +++ b/drivers/spi/spi-fsi.c
> @@ -528,13 +528,13 @@ static size_t fsi_spi_max_transfer_size(struct spi_device *spi)
> return SPI_FSI_MAX_RX_SIZE;
> }
>
> -static int fsi_spi_probe(struct device *dev)
> +static int fsi_spi_probe(struct fsi_device *fsi)
> {
> int rc;
> struct device_node *np;
> int num_controllers_registered = 0;
> struct fsi2spi *bridge;
> - struct fsi_device *fsi = to_fsi_dev(dev);
> + struct device *dev = &fsi->dev;
>
> rc = fsi_spi_check_mux(fsi, dev);
> if (rc)
> @@ -593,9 +593,9 @@ MODULE_DEVICE_TABLE(fsi, fsi_spi_ids);
>
> static struct fsi_driver fsi_spi_driver = {
> .id_table = fsi_spi_ids,
> + .probe = fsi_spi_probe,
> .drv = {
> .name = "spi-fsi",
> - .probe = fsi_spi_probe,
> },
> };
> module_fsi_driver(fsi_spi_driver);
next prev parent reply other threads:[~2026-01-27 15:30 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 11:39 [PATCH v2 00/13] fsi: Convert to " Uwe Kleine-König
2025-12-09 11:40 ` [PATCH v2 01/13] fsi: Make use of module_fsi_driver() Uwe Kleine-König
2026-01-27 15:25 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 02/13] fsi: Assign driver's bus in fsi_driver_register() Uwe Kleine-König
2026-01-27 15:25 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 03/13] fsi: Provide thin wrappers around dev_[gs]et_data() for fsi devices Uwe Kleine-König
2026-01-27 15:25 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 04/13] i2c: fsi: Drop assigning fsi bus Uwe Kleine-König
2026-01-27 15:26 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 05/13] spi: " Uwe Kleine-König
2026-01-27 15:26 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 06/13] fsi: Make fsi_bus_type a private variable to the core Uwe Kleine-König
2026-01-27 15:26 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 07/13] fsi: Create bus specific probe and remove functions Uwe Kleine-König
2026-01-27 15:27 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 08/13] fsi: i2cr-scom: Convert to fsi bus probe mechanism Uwe Kleine-König
2026-01-27 15:27 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 09/13] fsi: master: " Uwe Kleine-König
2026-01-27 15:27 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 10/13] fsi: sbefifo: " Uwe Kleine-König
2026-01-27 15:28 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 11/13] fsi: scom: " Uwe Kleine-König
2026-01-27 15:28 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 12/13] i2c: fsi: " Uwe Kleine-König
2026-01-27 15:29 ` Eddie James
2025-12-09 11:40 ` [PATCH v2 13/13] spi: " Uwe Kleine-König
2026-01-27 15:29 ` Eddie James [this message]
2026-01-12 9:47 ` [PATCH v2 00/13] fsi: Convert to " Uwe Kleine-König
2026-01-27 15:31 ` Eddie James
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e852b379-eb7b-4088-ad47-471ea1d755e2@linux.ibm.com \
--to=eajames@linux.ibm.com \
--cc=broonie@kernel.org \
--cc=linux-fsi@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=ninad@linux.ibm.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®