Re: [PATCH v2 01/13] fsi: Make use of module_fsi_driver()

[Eddie James <eajames@linux.ibm.com>]

On 12/9/25 5:40 AM, Uwe Kleine-König wrote:
> All other fsi drivers already use this helper to reduce boilerplate.
> Catch up for the last two remaining ones.


Acked-by: Eddie James <eajames@linux.ibm.com>


>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
>   drivers/fsi/fsi-sbefifo.c | 13 +------------
>   drivers/fsi/fsi-scom.c    | 13 +------------
>   2 files changed, 2 insertions(+), 24 deletions(-)
>
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index 0a98517f3959..5a08423d0c7e 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -1139,18 +1139,7 @@ static struct fsi_driver sbefifo_drv = {
>   	}
>   };
>   
> -static int sbefifo_init(void)
> -{
> -	return fsi_driver_register(&sbefifo_drv);
> -}
> -
> -static void sbefifo_exit(void)
> -{
> -	fsi_driver_unregister(&sbefifo_drv);
> -}
> -
> -module_init(sbefifo_init);
> -module_exit(sbefifo_exit);
> +module_fsi_driver(sbefifo_drv);
>   MODULE_LICENSE("GPL");
>   MODULE_AUTHOR("Brad Bishop <bradleyb@fuzziesquirrel.com>");
>   MODULE_AUTHOR("Eddie James <eajames@linux.vnet.ibm.com>");
> diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
> index 411ddc018cd8..f533106085ac 100644
> --- a/drivers/fsi/fsi-scom.c
> +++ b/drivers/fsi/fsi-scom.c
> @@ -613,17 +613,6 @@ static struct fsi_driver scom_drv = {
>   	}
>   };
>   
> -static int scom_init(void)
> -{
> -	return fsi_driver_register(&scom_drv);
> -}
> -
> -static void scom_exit(void)
> -{
> -	fsi_driver_unregister(&scom_drv);
> -}
> -
> -module_init(scom_init);
> -module_exit(scom_exit);
> +module_fsi_driver(scom_drv);
>   MODULE_DESCRIPTION("SCOM FSI Client device driver");
>   MODULE_LICENSE("GPL");