From: Jan Kiszka <jan.kiszka@siemens.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sascha Weisenberger <sascha.weisenberger@siemens.com>
Subject: Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency
Date: Mon, 22 May 2017 19:18:14 +0200 [thread overview]
Message-ID: <e8666da2-7883-29cc-6071-fe3d790345b9@siemens.com> (raw)
In-Reply-To: <CAHp75VfLJ_mLEts_C7tqaXRWs3E=+3TRddRJihYS2eDT=YMQJA@mail.gmail.com>
On 2017-05-22 19:12, Andy Shevchenko wrote:
> On Mon, May 22, 2017 at 1:53 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> Avoids reimplementation of DMI matching in intel_quark_i2c_setup.
>
> What's wrong with current approach? I suppose this will make sense
> when we will have an issue / impediment. Right now it looks like
> over-engineering.
>
> (Yes, I know what I said to you about this earlier, OTOH see above)
>
It allows matching on additional DMI tags without additional code -
patch 2 depends on it.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2017-05-22 17:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 10:53 [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000 Jan Kiszka
2017-05-22 10:53 ` [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: Use dmi_system_id table for retrieving frequency Jan Kiszka
2017-05-22 17:12 ` Andy Shevchenko
2017-05-22 17:18 ` Jan Kiszka [this message]
2017-05-22 17:20 ` Andy Shevchenko
2017-05-22 17:25 ` Jan Kiszka
2017-05-22 17:26 ` Andy Shevchenko
2017-05-22 17:34 ` Jan Kiszka
2017-05-22 17:36 ` Andy Shevchenko
2017-05-22 17:38 ` Jan Kiszka
2017-05-22 17:42 ` Andy Shevchenko
2017-05-22 18:23 ` Lee Jones
2017-05-22 18:37 ` Andy Shevchenko
2017-05-22 18:47 ` Jan Kiszka
2017-05-22 19:35 ` Andy Shevchenko
2017-05-22 10:53 ` [PATCH v2 2/2] mfd: intel_quark_i2c_gpio: Add support for SIMATIC IOT2000 platform Jan Kiszka
2017-05-23 15:02 ` [PATCH v2 0/2] mfd: intel_quark_i2c_gpio: Refactor and support for IOT2000 Andy Shevchenko
2017-05-30 8:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8666da2-7883-29cc-6071-fe3d790345b9@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=andy.shevchenko@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sascha.weisenberger@siemens.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®