mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paresh Bhagat <p-bhagat@ti.com>
To: Andrew Davis <afd@ti.com>, <nm@ti.com>, <vigneshr@ti.com>,
	<praneeth@ti.com>
Cc: <kristo@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
	<conor+dt@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<khasim@ti.com>, <v-singh1@ti.com>, <bb@ti.com>,
	<devarsht@ti.com>, <s-vadapalli@ti.com>, <andrew@lunn.ch>
Subject: Re: [PATCH v6 4/4] arm64: dts: ti: Add support for AM62D2-EVM
Date: Tue, 8 Jul 2025 14:13:35 +0530	[thread overview]
Message-ID: <e891ae83-39f2-44a9-b586-b11565559ce7@ti.com> (raw)
In-Reply-To: <a0eff32a-3307-409b-a6bc-5a3f1986c7ac@ti.com>

Hi Andrew,


On 07/07/25 21:35, Andrew Davis wrote:
> On 7/4/25 5:09 AM, Paresh Bhagat wrote:
>> AM62D-EVM evaluation module (EVM) is a low-cost expandable platform 
>> board
>> designed for AM62D2 SoC from TI. It supports the following interfaces:
>>
>> * 4 GB LPDDR4 RAM
>> * x2 Gigabit Ethernet expansion connectors
>> * x4 3.5mm TRS Audio Jack Line In
>> * x4 3.5mm TRS Audio Jack Line Out
>> * x2 Audio expansion connectors
>> * x1 Type-A USB 2.0, x1 Type-C dual-role device (DRD) USB 2.0
>> * x1 UHS-1 capable micro SD card slot
>> * 32 GB eMMC Flash
>> * 512 Mb OSPI NOR flash
>> * x4 UARTs via USB 2.0-B
>> * XDS110 for onboard JTAG debug using USB
>> * Temperature sensors, user push buttons and LEDs
>>
>> Although AM62D2 and AM62A7 differ in peripheral capabilities example
>> multimedia, VPAC, and display subsystems, the core architecture remains
>> same. To reduce duplication, AM62D support reuses the AM62A dtsi and the
>> necessary overrides will be handled in SOC specific dtsi file and a
>> board specific dts.
>>
>> Add basic support for AM62D2-EVM.
>>
>> Schematics Link - https://www.ti.com/lit/zip/sprcal5
>>
>> Signed-off-by: Paresh Bhagat <p-bhagat@ti.com>
>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/Makefile          |   3 +
>>   arch/arm64/boot/dts/ti/k3-am62d2-evm.dts | 617 +++++++++++++++++++++++
>>   arch/arm64/boot/dts/ti/k3-am62d2.dtsi    |  20 +
>>   3 files changed, 640 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/ti/k3-am62d2-evm.dts
>>   create mode 100644 arch/arm64/boot/dts/ti/k3-am62d2.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/ti/Makefile 
>> b/arch/arm64/boot/dts/ti/Makefile
>> index c6171de9fe88..3da3a1d1dc33 100644
>> --- a/arch/arm64/boot/dts/ti/Makefile
>> +++ b/arch/arm64/boot/dts/ti/Makefile
>> @@ -33,6 +33,9 @@ dtb-$(CONFIG_ARCH_K3) += k3-am62-pocketbeagle2.dtb
>>   dtb-$(CONFIG_ARCH_K3) += k3-am62a7-sk.dtb
>>   dtb-$(CONFIG_ARCH_K3) += k3-am62a7-phyboard-lyra-rdk.dtb
>>   +# Boards with AM62Dx SoC
>> +dtb-$(CONFIG_ARCH_K3) += k3-am62d2-evm.dtb
>> +
>>   # Boards with AM62Px SoC
>>   dtb-$(CONFIG_ARCH_K3) += k3-am62p5-sk.dtb
>>   dtb-$(CONFIG_ARCH_K3) += k3-am62p5-verdin-nonwifi-dahlia.dtb
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts 
>> b/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts
>> new file mode 100644
>> index 000000000000..715a407bddd8
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/ti/k3-am62d2-evm.dts
>> @@ -0,0 +1,617 @@
>> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
>> +/*
>> + * AM62D2 EVM: https://www.ti.com/lit/zip/sprcal5
>> + *
>> + * Copyright (C) 2025 Texas Instruments Incorporated - 
>> https://www.ti.com/
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include <dt-bindings/leds/common.h>
>> +#include <dt-bindings/gpio/gpio.h>
>> +#include <dt-bindings/net/ti-dp83867.h>
>> +#include "k3-am62d2.dtsi"
>> +
>> +/ {
>> +    compatible = "ti,am62d2-evm", "ti,am62d2";
>> +    model = "Texas Instruments AM62D2 EVM";
>> +
>> +    aliases {
>> +        serial0 = &wkup_uart0;
>> +        serial1 = &mcu_uart0;
>> +        serial2 = &main_uart0;
>> +        mmc0 = &sdhci0;
>> +        mmc1 = &sdhci1;
>> +        rtc0 = &wkup_rtc0;
>> +        ethernet0 = &cpsw_port1;
>> +        ethernet1 = &cpsw_port2;
>> +    };
>> +
>> +    chosen {
>> +        stdout-path = &main_uart0;
>> +    };
>> +
>> +    memory@80000000 {
>> +        device_type = "memory";
>> +        /* 4G RAM */
>> +        reg = <0x00000000 0x80000000 0x00000000 0x80000000>,
>> +              <0x00000008 0x80000000 0x00000000 0x80000000>;
>> +        bootph-all;
>> +    };
>> +
>> +    reserved-memory {
>> +        #address-cells = <2>;
>> +        #size-cells = <2>;
>> +        ranges;
>> +
>> +        /* global cma region */
>> +        linux,cma {
>> +            compatible = "shared-dma-pool";
>> +            reusable;
>> +            size = <0x00 0x2000000>;
>> +            alloc-ranges = <0x00 0xc0000000 0x00 0x2000000>;
>> +            linux,cma-default;
>> +        };
>> +
>> +        secure_tfa_ddr: tfa@80000000 {
>> +            reg = <0x00 0x80000000 0x00 0x80000>;
>> +            alignment = <0x1000>;
>
> "alignment" doesn't matter for "no-map" regions, Linux cannot allocate
> from these in the first place. Same for "secure_ddr" region below.
>
>> +            no-map;
>> +        };
>> +
>> +        c7x_0_dma_memory_region: c7x-dma-memory@99800000 {
>> +            compatible = "shared-dma-pool";
>> +            reg = <0x00 0x99800000 0x00 0x100000>;
>> +            no-map;
>> +        };
>> +
>> +        c7x_0_memory_region: c7x-memory@99900000 {
>> +            compatible = "shared-dma-pool";
>> +            reg = <0x00 0x99900000 0x00 0xf00000>;
>> +            no-map;
>> +        };
>> +
>> +        mcu_r5fss0_core0_dma_memory_region: r5f-dma-memory@9b800000 {
>> +            compatible = "shared-dma-pool";
>> +            reg = <0x00 0x9b800000 0x00 0x100000>;
>> +            no-map;
>> +        };
>> +
>> +        mcu_r5fss0_core0_memory_region: r5f-dma-memory@9b900000 {
>> +            compatible = "shared-dma-pool";
>> +            reg = <0x00 0x9b900000 0x00 0xf00000>;
>> +            no-map;
>> +        };
>> +
>> +        wkup_r5fss0_core0_dma_memory_region: r5f-dma-memory@9c800000 {
>> +            compatible = "shared-dma-pool";
>> +            reg = <0x00 0x9c800000 0x00 0x100000>;
>> +            no-map;
>> +        };
>> +
>> +        wkup_r5fss0_core0_memory_region: r5f-dma-memory@9c900000 {
>> +            compatible = "shared-dma-pool";
>> +            reg = <0x00 0x9c900000 0x00 0xf00000>;
>> +            no-map;
>> +            bootph-pre-ram;
>> +        };
>> +
>> +        secure_ddr: optee@9e800000 {
>> +            reg = <0x00 0x9e800000 0x00 0x01800000>; /* for OP-TEE */
>> +            alignment = <0x1000>;
>> +            no-map;
>> +        };
>> +
>> +        rtos_ipc_memory_region: ipc-memories@a0000000 {
>> +            compatible = "shared-dma-pool";
>> +            reg = <0x00 0xa0000000 0x00 0x01000000>;
>> +            no-map;
>> +        };
>> +    };
>> +
>> +    opp-table {
>> +        /* Requires VDD_CORE at 0v85 */
>> +        opp-1400000000 {
>> +            opp-hz = /bits/ 64 <1400000000>;
>> +            opp-supported-hw = <0x01 0x0004>;
>> +            clock-latency-ns = <6000000>;
>> +        };
>> +    };
>> +
>> +    vout_pd: regulator-0 {
>> +        /* TPS65988 PD CONTROLLER OUTPUT */
>> +        compatible = "regulator-fixed";
>> +        regulator-name = "vout_pd";
>> +        regulator-min-microvolt = <5000000>;
>> +        regulator-max-microvolt = <5000000>;
>> +        regulator-always-on;
>> +        regulator-boot-on;
>> +        bootph-all;
>> +    };
>> +
>> +    vmain_pd: regulator-1 {
>> +        /* Output of TPS22811 */
>> +        compatible = "regulator-fixed";
>> +        regulator-name = "vmain_pd";
>> +        regulator-min-microvolt = <5000000>;
>> +        regulator-max-microvolt = <5000000>;
>> +        vin-supply = <&vout_pd>;
>> +        regulator-always-on;
>> +        regulator-boot-on;
>> +        bootph-all;
>> +    };
>> +
>> +    vcc_5v0: regulator-2 {
>> +        /* Output of TPS630702RNMR */
>> +        compatible = "regulator-fixed";
>> +        regulator-name = "vcc_5v0";
>> +        regulator-min-microvolt = <5000000>;
>> +        regulator-max-microvolt = <5000000>;
>> +        vin-supply = <&vmain_pd>;
>> +        regulator-always-on;
>> +        regulator-boot-on;
>> +        bootph-all;
>> +    };
>> +
>> +    vcc_3v3_main: regulator-3 {
>> +        /* output of LM5141-Q1 */
>> +        compatible = "regulator-fixed";
>> +        regulator-name = "vcc_3v3_main";
>> +        regulator-min-microvolt = <3300000>;
>> +        regulator-max-microvolt = <3300000>;
>> +        vin-supply = <&vmain_pd>;
>> +        regulator-always-on;
>> +        regulator-boot-on;
>> +        bootph-all;
>> +    };
>> +
>> +    vdd_mmc1: regulator-4 {
>> +        /* TPS22918DBVR */
>> +        compatible = "regulator-fixed";
>> +        regulator-name = "vdd_mmc1";
>> +        regulator-min-microvolt = <3300000>;
>> +        regulator-max-microvolt = <3300000>;
>> +        regulator-boot-on;
>> +        enable-active-high;
>> +        gpio = <&exp1 3 GPIO_ACTIVE_HIGH>;
>> +        bootph-all;
>> +    };
>> +
>> +    vcc_3v3_sys: regulator-5 {
>> +        /* output of TPS222965DSGT */
>> +        compatible = "regulator-fixed";
>> +        regulator-name = "vcc_3v3_sys";
>> +        regulator-min-microvolt = <3300000>;
>> +        regulator-max-microvolt = <3300000>;
>> +        vin-supply = <&vcc_3v3_main>;
>> +        regulator-always-on;
>> +        regulator-boot-on;
>> +        bootph-all;
>> +    };
>> +
>> +    vddshv_sdio: regulator-6 {
>> +        compatible = "regulator-gpio";
>> +        regulator-name = "vddshv_sdio";
>> +        pinctrl-names = "default";
>> +        pinctrl-0 = <&vddshv_sdio_pins_default>;
>> +        regulator-min-microvolt = <1800000>;
>> +        regulator-max-microvolt = <3300000>;
>> +        regulator-boot-on;
>> +        gpios = <&main_gpio1 31 GPIO_ACTIVE_HIGH>;
>> +        states = <1800000 0x0>,
>> +             <3300000 0x1>;
>> +        bootph-all;
>> +    };
>> +
>> +    leds {
>> +        compatible = "gpio-leds";
>> +        pinctrl-names = "default";
>> +        pinctrl-0 = <&usr_led_pins_default>;
>> +
>> +        led-0 {
>> +            label = "am62d-evm:green:heartbeat";
>> +            gpios = <&main_gpio1 49 GPIO_ACTIVE_HIGH>;
>> +            linux,default-trigger = "heartbeat";
>> +            function = LED_FUNCTION_HEARTBEAT;
>> +            default-state = "off";
>> +        };
>> +    };
>> +};
>> +
>> +&mcu_pmx0 {
>> +    status = "okay";
>> +
>> +    pmic_irq_pins_default: pmic-irq-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_MCU_IOPAD(0x000, PIN_INPUT, 7) /* (E11) 
>> MCU_GPIO0_0 */
>> +        >;
>> +    };
>> +
>> +    wkup_uart0_pins_default: wkup-uart0-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_MCU_IOPAD(0x0024, PIN_INPUT, 0) /* (C9) 
>> WKUP_UART0_RXD */
>> +            AM62DX_MCU_IOPAD(0x0028, PIN_OUTPUT, 0) /* (E9) 
>> WKUP_UART0_TXD */
>> +            AM62DX_MCU_IOPAD(0x002c, PIN_INPUT, 0) /* (C10) 
>> WKUP_UART0_CTSn */
>> +            AM62DX_MCU_IOPAD(0x0030, PIN_OUTPUT, 0) /* (C8) 
>> WKUP_UART0_RTSn */
>> +        >;
>> +        bootph-all;
>> +    };
>> +};
>> +
>> +/* WKUP UART0 is used for DM firmware logs */
>> +&wkup_uart0 {
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&wkup_uart0_pins_default>;
>> +    bootph-all;
>> +    status = "reserved";
>> +};
>> +
>> +&main_pmx0 {
>> +    main_uart0_pins_default: main-uart0-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x01c8, PIN_INPUT, 0) /* (E14) UART0_RXD */
>> +            AM62DX_IOPAD(0x01cc, PIN_OUTPUT, 0) /* (D15) UART0_TXD */
>> +        >;
>> +        bootph-all;
>> +    };
>> +
>> +    main_i2c0_pins_default: main-i2c0-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x01e0, PIN_INPUT_PULLUP, 0) /* (D17) 
>> I2C0_SCL */
>> +            AM62DX_IOPAD(0x01e4, PIN_INPUT_PULLUP, 0) /* (E16) 
>> I2C0_SDA */
>> +        >;
>> +        bootph-all;
>> +    };
>> +
>> +    main_i2c1_pins_default: main-i2c1-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x01e8, PIN_INPUT_PULLUP, 0) /* (C17) 
>> I2C1_SCL */
>> +            AM62DX_IOPAD(0x01ec, PIN_INPUT_PULLUP, 0) /* (E17) 
>> I2C1_SDA */
>> +        >;
>> +        bootph-all;
>> +    };
>> +
>> +    main_i2c2_pins_default: main-i2c2-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x00b0, PIN_INPUT_PULLUP, 1) /* (M22) 
>> GPMC0_CSn2.I2C2_SCL */
>> +            AM62DX_IOPAD(0x00b4, PIN_INPUT_PULLUP, 1) /* (M20) 
>> GPMC0_CSn3.I2C2_SDA */
>> +        >;
>> +    };
>> +
>> +    main_mmc0_pins_default: main-mmc0-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x0220, PIN_INPUT_PULLUP, 0) /* (Y6) 
>> MMC0_CMD */
>> +            AM62DX_IOPAD(0x0218, PIN_OUTPUT, 0) /* (AB7) MMC0_CLK */
>> +            AM62DX_IOPAD(0x0214, PIN_INPUT_PULLUP, 0) /* (AA6) 
>> MMC0_DAT0 */
>> +            AM62DX_IOPAD(0x0210, PIN_INPUT_PULLUP, 0) /* (AB6) 
>> MMC0_DAT1 */
>> +            AM62DX_IOPAD(0x020c, PIN_INPUT_PULLUP, 0) /* (Y7) 
>> MMC0_DAT2 */
>> +            AM62DX_IOPAD(0x0208, PIN_INPUT_PULLUP, 0) /* (AA7) 
>> MMC0_DAT3 */
>> +            AM62DX_IOPAD(0x0204, PIN_INPUT_PULLUP, 0) /* (Y8) 
>> MMC0_DAT4 */
>> +            AM62DX_IOPAD(0x0200, PIN_INPUT_PULLUP, 0) /* (W7) 
>> MMC0_DAT5 */
>> +            AM62DX_IOPAD(0x01fc, PIN_INPUT_PULLUP, 0) /* (W9) 
>> MMC0_DAT6 */
>> +            AM62DX_IOPAD(0x01f8, PIN_INPUT_PULLUP, 0) /* (AB8) 
>> MMC0_DAT7 */
>> +        >;
>> +        bootph-all;
>> +    };
>> +
>> +    main_mmc1_pins_default: main-mmc1-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x023c, PIN_INPUT, 0) /* (C21) MMC1_CMD */
>> +            AM62DX_IOPAD(0x0234, PIN_OUTPUT, 0) /* (E22) MMC1_CLK */
>> +            AM62DX_IOPAD(0x0230, PIN_INPUT, 0) /* (B22) MMC1_DAT0 */
>> +            AM62DX_IOPAD(0x022c, PIN_INPUT, 0) /* (D21) MMC1_DAT1 */
>> +            AM62DX_IOPAD(0x0228, PIN_INPUT, 0) /* (C22) MMC1_DAT2 */
>> +            AM62DX_IOPAD(0x0224, PIN_INPUT, 0) /* (D22) MMC1_DAT3 */
>> +            AM62DX_IOPAD(0x0240, PIN_INPUT, 0) /* (E18) MMC1_SDCD */
>> +        >;
>> +        bootph-all;
>> +    };
>> +
>> +    main_mdio0_pins_default: main-mdio0-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x160, PIN_OUTPUT, 0) /* (V12) MDIO0_MDC */
>> +            AM62DX_IOPAD(0x15c, PIN_INPUT, 0) /* (V13) MDIO0_MDIO */
>> +        >;
>> +        bootph-all;
>> +    };
>> +
>> +    main_rgmii1_pins_default: main-rgmii1-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x14c, PIN_INPUT, 0) /* (AB16) RGMII1_RD0 */
>> +            AM62DX_IOPAD(0x150, PIN_INPUT, 0) /* (V15) RGMII1_RD1 */
>> +            AM62DX_IOPAD(0x154, PIN_INPUT, 0) /* (W15) RGMII1_RD2 */
>> +            AM62DX_IOPAD(0x158, PIN_INPUT, 0) /* (V14) RGMII1_RD3 */
>> +            AM62DX_IOPAD(0x148, PIN_INPUT, 0) /* (AA16) RGMII1_RXC */
>> +            AM62DX_IOPAD(0x144, PIN_INPUT, 0) /* (AA15) 
>> RGMII1_RX_CTL */
>> +            AM62DX_IOPAD(0x134, PIN_INPUT, 0) /* (Y17) RGMII1_TD0 */
>> +            AM62DX_IOPAD(0x138, PIN_INPUT, 0) /* (V16) RGMII1_TD1 */
>> +            AM62DX_IOPAD(0x13c, PIN_INPUT, 0) /* (Y16) RGMII1_TD2 */
>> +            AM62DX_IOPAD(0x140, PIN_INPUT, 0) /* (AA17) RGMII1_TD3 */
>> +            AM62DX_IOPAD(0x0130, PIN_OUTPUT, 0) /* (AB17) RGMII1_TXC */
>> +            AM62DX_IOPAD(0x012c, PIN_OUTPUT, 0) /* (W16) 
>> RGMII1_TX_CTL */
>> +        >;
>> +        bootph-all;
>> +    };
>> +
>> +    main_rgmii2_pins_default: main-rgmii2-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x0184, PIN_INPUT, 0) /* (AA21) RGMII2_RD0 */
>> +            AM62DX_IOPAD(0x0188, PIN_INPUT, 0) /* (Y20) RGMII2_RD1 */
>> +            AM62DX_IOPAD(0x018c, PIN_INPUT, 0) /* (AB21) RGMII2_RD2 */
>> +            AM62DX_IOPAD(0x0190, PIN_INPUT, 0) /* (AB20) RGMII2_RD3 */
>> +            AM62DX_IOPAD(0x0180, PIN_INPUT, 0) /* (AA20) RGMII2_RXC */
>> +            AM62DX_IOPAD(0x017c, PIN_INPUT, 0) /* (W18) 
>> RGMII2_RX_CTL */
>> +            AM62DX_IOPAD(0x016c, PIN_INPUT, 0) /* (AA19) RGMII2_TD0 */
>> +            AM62DX_IOPAD(0x0170, PIN_INPUT, 0) /* (Y18) RGMII2_TD1 */
>> +            AM62DX_IOPAD(0x0174, PIN_INPUT, 0) /* (AA18) RGMII2_TD2 */
>> +            AM62DX_IOPAD(0x0178, PIN_INPUT, 0) /* (W17) RGMII2_TD3 */
>> +            AM62DX_IOPAD(0x0168, PIN_OUTPUT, 0) /* (AB19) RGMII2_TXC */
>> +            AM62DX_IOPAD(0x0164, PIN_OUTPUT, 0) /* (Y19) 
>> RGMII2_TX_CTL */
>> +        >;
>> +        bootph-all;
>> +    };
>> +
>> +    main_gpio1_ioexp_intr_pins_default: 
>> main-gpio1-ioexp-intr-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x01d4, PIN_INPUT, 7) /* (C15) 
>> UART0_RTSn.GPIO1_23 */
>> +        >;
>> +    };
>> +
>> +    vddshv_sdio_pins_default: vddshv-sdio-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x1f4, PIN_OUTPUT, 7) /* (M19) 
>> GPMC0_CLK.GPIO1_31 */
>> +        >;
>> +        bootph-all;
>> +    };
>> +
>> +    usr_led_pins_default: usr-led-default-pins {
>> +        pinctrl-single,pins = <
>> +            AM62DX_IOPAD(0x0244, PIN_INPUT, 7) /* (D18) 
>> MMC1_SDWP.GPIO1_49 */
>> +        >;
>> +    };
>> +};
>> +
>> +&mcu_gpio0 {
>> +    status = "okay";
>> +};
>> +
>> +&main_i2c0 {
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&main_i2c0_pins_default>;
>> +    clock-frequency = <400000>;
>> +    bootph-all;
>> +    status = "okay";
>> +
>> +    typec_pd0: usb-power-controller@3f {
>> +        compatible = "ti,tps6598x";
>> +        reg = <0x3f>;
>> +
>> +        connector {
>> +            compatible = "usb-c-connector";
>> +            label = "USB-C";
>> +            self-powered;
>> +            data-role = "dual";
>> +            power-role = "sink";
>> +            port {
>> +                usb_con_hs: endpoint {
>> +                    remote-endpoint = <&usb0_hs_ep>;
>> +                };
>> +            };
>> +        };
>> +    };
>> +
>> +    exp1: gpio@22 {
>> +        compatible = "ti,tca6424";
>> +        reg = <0x22>;
>> +        gpio-controller;
>> +        #gpio-cells = <2>;
>> +        interrupt-parent = <&main_gpio1>;
>> +        interrupts = <23 IRQ_TYPE_EDGE_FALLING>;
>> +        interrupt-controller;
>> +        #interrupt-cells = <2>;
>> +        pinctrl-names = "default";
>> +        pinctrl-0 = <&main_gpio1_ioexp_intr_pins_default>;
>> +        bootph-all;
>> +
>> +        gpio-line-names = "GPIO_CPSW2_RST", "GPIO_CPSW1_RST",
>> +                  "","MMC1_SD_EN",
>> +                  "VPP_EN", "GPIO_DIX_RST",
>> +                  "IO_EXP_OPT_EN", "DIX_INT",
>> +                  "GPIO_eMMC_RSTn", "CPLD2_DONE",
>> +                  "CPLD2_INTN", "CPLD1_DONE",
>> +                  "CPLD1_INTN", "USB_TYPEA_OC_INDICATION",
>> +                  "PCM1_INT", "PCM2_INT",
>> +                  "GPIO_PCM1_RST", "TEST_GPIO2",
>> +                  "GPIO_PCM2_RST", "",
>> +                  "IO_MCAN0_STB", "IO_MCAN1_STB",
>> +                  "PD_I2C_IRQ", "IO_EXP_TEST_LED";
>> +    };
>> +
>> +    exp2: gpio@20 {
>> +        compatible = "ti,tca6416";
>> +        reg = <0x20>;
>> +        gpio-controller;
>> +        #gpio-cells = <2>;
>> +
>> +        gpio-line-names = "PCM6240_BUF_IO_EN", "",
>> +                  "CPLD1_JTAGENB", "CPLD1_PROGRAMN",
>> +                  "CPLD2_JTAGENB", "CPLD2_PROGRAMN",
>> +                  "", "",
>> +                  "", "CPLD1_TCK",
>> +                  "CPLD1_TMS", "CPLD1_TDI",
>> +                  "CPLD1_TDO", "CPLD2_TCK",
>> +                  "CPLD2_TMS", "CPLD2_TDI",
>> +                  "CPLD2_TDO", "ADDR1_IO_EXP",
>> +                  "SoC_I2C0_SCL", "SoC_I2C0_SDA";
>> +    };
>> +};
>> +
>> +&main_i2c1 {
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&main_i2c1_pins_default>;
>> +    clock-frequency = <100000>;
>> +    status = "okay";
>> +};
>> +
>> +&main_i2c2 {
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&main_i2c2_pins_default>;
>> +    clock-frequency = <400000>;
>> +    status = "okay";
>> +};
>> +
>> +&sdhci0 {
>> +    /* eMMC */
>> +    non-removable;
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&main_mmc0_pins_default>;
>> +    bootph-all;
>> +    status = "okay";
>> +};
>> +
>> +&sdhci1 {
>> +    /* SD/MMC */
>> +    vmmc-supply = <&vdd_mmc1>;
>> +    vqmmc-supply = <&vddshv_sdio>;
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&main_mmc1_pins_default>;
>> +    disable-wp;
>> +    bootph-all;
>> +    status = "okay";
>> +};
>> +
>> +&main_gpio0 {
>> +    bootph-all;
>> +    status = "okay";
>> +};
>> +
>> +&main_gpio1 {
>> +    bootph-all;
>> +    status = "okay";
>> +};
>> +
>> +&main_gpio_intr {
>> +    status = "okay";
>> +};
>> +
>> +&main_uart0 {
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&main_uart0_pins_default>;
>> +    bootph-all;
>> +    status = "okay";
>> +};
>> +
>> +&usb0 {
>> +    usb-role-switch;
>> +
>> +    port {
>> +        usb0_hs_ep: endpoint {
>> +            remote-endpoint = <&usb_con_hs>;
>> +        };
>> +    };
>> +};
>> +
>> +&cpsw3g {
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&main_rgmii1_pins_default>,
>> +            <&main_rgmii2_pins_default>;
>> +    status = "okay";
>> +
>> +    cpts@3d000 {
>> +        /* MAP HW3_TS_PUSH to GENF1 */
>> +        ti,pps = <2 1>;
>> +    };
>> +};
>> +
>> +&cpsw_port1 {
>> +    phy-mode = "rgmii-id";
>> +    phy-handle = <&cpsw3g_phy0>;
>> +    status = "okay";
>> +};
>> +
>> +&cpsw_port2 {
>> +    phy-mode = "rgmii-id";
>> +    phy-handle = <&cpsw3g_phy1>;
>> +    status = "okay";
>> +};
>> +
>> +&cpsw3g_mdio {
>> +    pinctrl-names = "default";
>> +    pinctrl-0 = <&main_mdio0_pins_default>;
>> +    status = "okay";
>> +
>> +    cpsw3g_phy0: ethernet-phy@0 {
>> +        reg = <0>;
>> +        ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
>> +        ti,min-output-impedance;
>> +    };
>> +
>> +    cpsw3g_phy1: ethernet-phy@3 {
>> +        reg = <3>;
>> +        ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
>> +        ti,min-output-impedance;
>> +    };
>> +};
>> +
>> +&mailbox0_cluster0 {
>> +    status = "okay";
>> +
>> +    mbox_r5_0: mbox-r5-0 {
>> +        ti,mbox-rx = <0 0 0>;
>> +        ti,mbox-tx = <1 0 0>;
>> +    };
>> +};
>> +
>> +&mailbox0_cluster1 {
>> +    status = "okay";
>> +
>> +    mbox_c7x_0: mbox-c7x-0 {
>> +        ti,mbox-rx = <0 0 0>;
>> +        ti,mbox-tx = <1 0 0>;
>> +    };
>> +};
>> +
>> +&mailbox0_cluster2 {
>> +    status = "okay";
>> +
>> +    mbox_mcu_r5_0: mbox-mcu-r5-0 {
>> +        ti,mbox-rx = <0 0 0>;
>> +        ti,mbox-tx = <1 0 0>;
>> +    };
>> +};
>> +
>> +&wkup_r5fss0 {
>> +    status = "okay";
>> +};
>> +
>> +&wkup_r5fss0_core0 {
>> +    mboxes = <&mailbox0_cluster0 &mbox_r5_0>;
>> +    memory-region = <&wkup_r5fss0_core0_dma_memory_region>,
>> +            <&wkup_r5fss0_core0_memory_region>;
>> +    bootph-pre-ram;
>> +};
>> +
>> +&mcu_r5fss0 {
>> +    status = "okay";
>> +};
>> +
>> +&mcu_r5fss0_core0 {
>> +    mboxes = <&mailbox0_cluster2 &mbox_mcu_r5_0>;
>> +    memory-region = <&mcu_r5fss0_core0_dma_memory_region>,
>> +            <&mcu_r5fss0_core0_memory_region>;
>> +    firmware-name = "am62d-mcu-r5f0_0-fw";
>> +    status = "okay";
>> +};
>> +
>> +&c7x_0 {
>> +    mboxes = <&mailbox0_cluster1 &mbox_c7x_0>;
>> +    memory-region = <&c7x_0_dma_memory_region>,
>> +            <&c7x_0_memory_region>;
>> +    firmware-name = "am62d-c71_0-fw";
>> +    status = "okay";
>> +};
>> +
>> +/* main_rti4 is used by C7x DSP */
>> +&main_rti4 {
>> +    status = "reserved";
>> +};
>> diff --git a/arch/arm64/boot/dts/ti/k3-am62d2.dtsi 
>> b/arch/arm64/boot/dts/ti/k3-am62d2.dtsi
>> new file mode 100644
>> index 000000000000..1095515d3780
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/ti/k3-am62d2.dtsi
>> @@ -0,0 +1,20 @@
>> +// SPDX-License-Identifier: GPL-2.0-only OR MIT
>> +/*
>> + * Device Tree Source for AM62D2 SoC family in Quad core configuration
>> + *
>> + * TRM: https://www.ti.com/lit/pdf/sprujd4
>> + *
>> + * Copyright (C) 2025 Texas Instruments Incorporated - 
>> https://www.ti.com/
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "k3-am62a7.dtsi"
>> +
>> +/ {
>> +    model = "Texas Instruments K3 AM62D SoC";
>> +    compatible = "ti,am62d2";
>> +};
>> +
>> +/delete-node/ &vpu;   /* Delete video codec node */
>> +/delete-node/ &e5010; /* Delete jpeg encoder node */
>
> No need for comments that repeat the code, we can read the
> code, comments should explain the "why". In this case something
> like "/* The xxx is disabled in the AM62D2 SoC */
>
> Otherwise looks good enough for basic support,
>
> Reviewed-by: Andrew Davis <afd@ti.com>


Thanks for the review. will update in next version.

  reply	other threads:[~2025-07-08  8:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04 10:09 [PATCH v6 0/4] Add support for AM62D2 SoC and EVM Paresh Bhagat
2025-07-04 10:09 ` [PATCH v6 1/4] arm64: dts: ti: Add bootph property to nodes at source for am62a Paresh Bhagat
2025-07-07 16:35   ` Bryan Brattlof
2025-07-04 10:09 ` [PATCH v6 2/4] dt-bindings: arm: ti: Add AM62D2 SoC and Boards Paresh Bhagat
2025-07-04 10:09 ` [PATCH v6 3/4] arm64: dts: ti: Add pinctrl entries for AM62D2 family of SoCs Paresh Bhagat
2025-07-08  6:13   ` Devarsh Thakkar
2025-07-04 10:09 ` [PATCH v6 4/4] arm64: dts: ti: Add support for AM62D2-EVM Paresh Bhagat
2025-07-07 16:05   ` Andrew Davis
2025-07-08  8:43     ` Paresh Bhagat [this message]
2025-07-07 16:37   ` Bryan Brattlof

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e891ae83-39f2-44a9-b586-b11565559ce7@ti.com \
    --to=p-bhagat@ti.com \
    --cc=afd@ti.com \
    --cc=andrew@lunn.ch \
    --cc=bb@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=khasim@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=praneeth@ti.com \
    --cc=robh@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=v-singh1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®