[PATCH] hwmon: abituguru: Remove unused ABITUGURU_TEMP_NAMES_LENGTH macro

[PATCH] hwmon: abituguru: Remove unused ABITUGURU_TEMP_NAMES_LENGTH macro

[Ba Jing]

The macro ABITUGURU_TEMP_NAMES_LENGTH is never referenced in the code. Remove it.

Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
---
 drivers/hwmon/abituguru.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/hwmon/abituguru.c b/drivers/hwmon/abituguru.c
index 93653ea05430..58072af4676b 100644
--- a/drivers/hwmon/abituguru.c
+++ b/drivers/hwmon/abituguru.c
@@ -95,11 +95,6 @@
  * in??_{min,max}_alarm_enable\0, in??_beep\0, in??_shutdown\0
  */
 #define ABITUGURU_IN_NAMES_LENGTH	(11 + 2 * 9 + 2 * 15 + 2 * 22 + 10 + 14)
-/*
- * sum of strlen of: temp??_input\0, temp??_max\0, temp??_crit\0,
- * temp??_alarm\0, temp??_alarm_enable\0, temp??_beep\0, temp??_shutdown\0
- */
-#define ABITUGURU_TEMP_NAMES_LENGTH	(13 + 11 + 12 + 13 + 20 + 12 + 16)
 /*
  * sum of strlen of: fan?_input\0, fan?_min\0, fan?_alarm\0,
  * fan?_alarm_enable\0, fan?_beep\0, fan?_shutdown\0
-- 
2.33.0

Re: [PATCH] hwmon: abituguru: Remove unused ABITUGURU_TEMP_NAMES_LENGTH macro

[Hans de Goede]

Hi,

On 3-Sep-24 4:50 AM, Ba Jing wrote:
> The macro ABITUGURU_TEMP_NAMES_LENGTH is never referenced in the code. Remove it.
> 
> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
> ---
>  drivers/hwmon/abituguru.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/hwmon/abituguru.c b/drivers/hwmon/abituguru.c
> index 93653ea05430..58072af4676b 100644
> --- a/drivers/hwmon/abituguru.c
> +++ b/drivers/hwmon/abituguru.c
> @@ -95,11 +95,6 @@
>   * in??_{min,max}_alarm_enable\0, in??_beep\0, in??_shutdown\0
>   */
>  #define ABITUGURU_IN_NAMES_LENGTH	(11 + 2 * 9 + 2 * 15 + 2 * 22 + 10 + 14)
> -/*
> - * sum of strlen of: temp??_input\0, temp??_max\0, temp??_crit\0,
> - * temp??_alarm\0, temp??_alarm_enable\0, temp??_beep\0, temp??_shutdown\0
> - */
> -#define ABITUGURU_TEMP_NAMES_LENGTH	(13 + 11 + 12 + 13 + 20 + 12 + 16)
>  /*
>   * sum of strlen of: fan?_input\0, fan?_min\0, fan?_alarm\0,
>   * fan?_alarm_enable\0, fan?_beep\0, fan?_shutdown\0

ABITUGURU_TEMP_NAMES_LENGTH is used further down buy only in a comment:

/* IN_NAMES_LENGTH > TEMP_NAMES_LENGTH so assume all bank1 sensors are in */
#define ABITUGURU_SYSFS_NAMES_LENGTH    ( \
        ABIT_UGURU_MAX_BANK1_SENSORS * ABITUGURU_IN_NAMES_LENGTH + \
        ABIT_UGURU_MAX_BANK2_SENSORS * ABITUGURU_FAN_NAMES_LENGTH + \
        ABIT_UGURU_MAX_PWMS * ABITUGURU_PWM_NAMES_LENGTH)

So IMHO ABITUGURU_TEMP_NAMES_LENGTH should stay so that someone
reading the comment will actually be able to understand things,
removing ABITUGURU_TEMP_NAMES_LENGTH makes the comment very
hard to understand and we want to keep the comment.

So NACK from me for this change.

Regards,

Hans

Re: [PATCH] hwmon: abituguru: Remove unused ABITUGURU_TEMP_NAMES_LENGTH macro

[Guenter Roeck]

On 9/20/24 05:10, Hans de Goede wrote:
> Hi,
> 
> On 3-Sep-24 4:50 AM, Ba Jing wrote:
>> The macro ABITUGURU_TEMP_NAMES_LENGTH is never referenced in the code. Remove it.
>>
>> Signed-off-by: Ba Jing <bajing@cmss.chinamobile.com>
>> ---
>>   drivers/hwmon/abituguru.c | 5 -----
>>   1 file changed, 5 deletions(-)
>>
>> diff --git a/drivers/hwmon/abituguru.c b/drivers/hwmon/abituguru.c
>> index 93653ea05430..58072af4676b 100644
>> --- a/drivers/hwmon/abituguru.c
>> +++ b/drivers/hwmon/abituguru.c
>> @@ -95,11 +95,6 @@
>>    * in??_{min,max}_alarm_enable\0, in??_beep\0, in??_shutdown\0
>>    */
>>   #define ABITUGURU_IN_NAMES_LENGTH	(11 + 2 * 9 + 2 * 15 + 2 * 22 + 10 + 14)
>> -/*
>> - * sum of strlen of: temp??_input\0, temp??_max\0, temp??_crit\0,
>> - * temp??_alarm\0, temp??_alarm_enable\0, temp??_beep\0, temp??_shutdown\0
>> - */
>> -#define ABITUGURU_TEMP_NAMES_LENGTH	(13 + 11 + 12 + 13 + 20 + 12 + 16)
>>   /*
>>    * sum of strlen of: fan?_input\0, fan?_min\0, fan?_alarm\0,
>>    * fan?_alarm_enable\0, fan?_beep\0, fan?_shutdown\0
> 
> ABITUGURU_TEMP_NAMES_LENGTH is used further down buy only in a comment:
> 
> /* IN_NAMES_LENGTH > TEMP_NAMES_LENGTH so assume all bank1 sensors are in */
> #define ABITUGURU_SYSFS_NAMES_LENGTH    ( \
>          ABIT_UGURU_MAX_BANK1_SENSORS * ABITUGURU_IN_NAMES_LENGTH + \
>          ABIT_UGURU_MAX_BANK2_SENSORS * ABITUGURU_FAN_NAMES_LENGTH + \
>          ABIT_UGURU_MAX_PWMS * ABITUGURU_PWM_NAMES_LENGTH)
> 
> So IMHO ABITUGURU_TEMP_NAMES_LENGTH should stay so that someone
> reading the comment will actually be able to understand things,
> removing ABITUGURU_TEMP_NAMES_LENGTH makes the comment very
> hard to understand and we want to keep the comment.
> 
> So NACK from me for this change.
> 

Marked as rejected.

Thanks,
Guenter