Re: [PATCH 1/2] dt-bindings: arm: mediatek: Add Lenovo YOGA Tablet 8/10

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 04/03/26 20:24, Akari Tsuyukusa ha scritto:
> Add the "lenovo,blade" compatible string for the Lenovo YOGA Tablet 8/10
> family and add compatible strings for each board
> (B6000-F, B6000-H, B8000-F, B8000-H).

You're adding support (a devicetree) only for the B8000-F though...

> 
> These tablets are based on the "blade" platform, featuring 1GB of RAM
> and powered by MediaTek MT8125 or MT8389 SoCs. Since these SoCs are
> tablet-oriented variants of the MT6589, they are grouped under the
> "mediatek,mt6589" compatible string.
> 
> Signed-off-by: Akari Tsuyukusa <akkun11.open@gmail.com>
> ---
>   Documentation/devicetree/bindings/arm/mediatek.yaml | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index 382d0eb4d0af..69dbe389515c 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -44,6 +44,11 @@ properties:
>         - items:
>             - enum:
>                 - fairphone,fp1
> +              - lenovo,b6000-f
> +              - lenovo,b6000-h
> +              - lenovo,b8000-f
> +              - lenovo,b8000-h
> +              - lenovo,blade
>                 - mundoreader,bq-aquaris5
>             - const: mediatek,mt6589
>         - items:

Did you really test this with dtbs_check?

...also, is the "lenovo,blade" really used for anything (bootloader)?

You can either fix that or just remove the lenovo,blade compatible... but please,
test with `make dtbs_check` before sending a v2 :-)

Cheers,
Angelo