Re: [PATCH 2/2] arm: dts: mediatek: mt6589: add basic support for Lenovo B8000-F

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 12/03/26 05:36, Akari Tsuyukusa ha scritto:
> On Fri, Mar 6, 2026 at 11:06 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>> Ouch. Well, it's mostly done then, hopefully sooner than later :-)
> 
> Thank you for your consideration.
> 
>>> - PWRAP and MT6320 PMIC RTC
>> Start upstreaming the RTC (and MFD parts) right now maybe?
>> That all depends on the actual state of things, of course.
>>
>> Remember that you can upstream whatever is clean and works fine, that doesn't
>> have hard dependencies on other components.
> 
> mediatek,mt6397.yaml says that "regulators are needed",

ARGH! Forgot about that :-)

> so I have to complete the regulator driver.
> It will be completed soon.
> 
>>> - Power Domains (scpsys)
>>
>> The power domains should be handled by mtk-pm-domains.c - not sure what you wrote
>> but if you did it on mtk-scpsys.c that's wrong.
> 
> Ohno! I wrote in mtk-scpsys.c, thank you for telling me about this.
> 

I really have to add a comment in that driver saying that it's deprecated and it
shall never be used ever again, if not for already present legacy SoCs, which
should get anyway migrated to mtk-pm-domains for good measure (but I don't have
any of those, and I can't do that myself).

>>> - eMMC/SD (MSDC)
>> I can confirm that the MSDC controller in MT6589 will work with mtk-sd, there may
>> be some very small modifications to be done.... if any.
>> The mtk-sd driver does support "very old" SoCs already :-)
> 
> I forgot to add "CONFIG_REGULATOR_FIXED_VOLTAGE=y".
> SD is working and can boot from it.
> However, increasing the frequency causes errors,
> so adjustments are necessary.

Told ya! :-)

Cool to know that you're getting nicer and nicer progress over this!

> 
>> Keep up the good work!
> 
> I will continue to do my best!
> Further news will be sent via patch.
> 

Patiently waiting, and excited to see the news!

Cheers,
Angelo