* [PATCH] net: bridge: remove redundant return
@ 2021-06-23 0:53 13145886936
2021-06-23 10:51 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: 13145886936 @ 2021-06-23 0:53 UTC (permalink / raw)
To: roopa, nikolay, davem, kuba; +Cc: netdev, linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
Return statements are not needed in Void function.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
net/bridge/br_netlink.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 8642e56059fb..b70075939721 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -619,7 +619,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br,
{
u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED;
- return br_info_notify(event, br, port, filter);
+ br_info_notify(event, br, port, filter);
}
/*
@@ -814,7 +814,7 @@ static const struct nla_policy br_port_policy[IFLA_BRPORT_MAX + 1] = {
[IFLA_BRPORT_MODE] = { .type = NLA_U8 },
[IFLA_BRPORT_GUARD] = { .type = NLA_U8 },
[IFLA_BRPORT_PROTECT] = { .type = NLA_U8 },
- [IFLA_BRPORT_FAST_LEAVE]= { .type = NLA_U8 },
+ [IFLA_BRPORT_FAST_LEAVE] = { .type = NLA_U8 },
[IFLA_BRPORT_LEARNING] = { .type = NLA_U8 },
[IFLA_BRPORT_UNICAST_FLOOD] = { .type = NLA_U8 },
[IFLA_BRPORT_PROXYARP] = { .type = NLA_U8 },
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] net: bridge: remove redundant return
2021-06-23 0:53 [PATCH] net: bridge: remove redundant return 13145886936
@ 2021-06-23 10:51 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2021-06-23 10:51 UTC (permalink / raw)
To: 13145886936, roopa, nikolay, davem, kuba
Cc: netdev, linux-kernel, gushengxian
On 6/23/21 2:53 AM, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> Return statements are not needed in Void function.
Maybe, but this just works.
I see your patch as a matter of taste.
>
> Signed-off-by: gushengxian <gushengxian@yulong.com>
> ---
> net/bridge/br_netlink.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
> index 8642e56059fb..b70075939721 100644
> --- a/net/bridge/br_netlink.c
> +++ b/net/bridge/br_netlink.c
> @@ -619,7 +619,7 @@ void br_ifinfo_notify(int event, const struct net_bridge *br,
> {
> u32 filter = RTEXT_FILTER_BRVLAN_COMPRESSED;
>
> - return br_info_notify(event, br, port, filter);
> + br_info_notify(event, br, port, filter);
> }
>
> /*
> @@ -814,7 +814,7 @@ static const struct nla_policy br_port_policy[IFLA_BRPORT_MAX + 1] = {
> [IFLA_BRPORT_MODE] = { .type = NLA_U8 },
> [IFLA_BRPORT_GUARD] = { .type = NLA_U8 },
> [IFLA_BRPORT_PROTECT] = { .type = NLA_U8 },
> - [IFLA_BRPORT_FAST_LEAVE]= { .type = NLA_U8 },
> + [IFLA_BRPORT_FAST_LEAVE] = { .type = NLA_U8 },
Useless noise.
> [IFLA_BRPORT_LEARNING] = { .type = NLA_U8 },
> [IFLA_BRPORT_UNICAST_FLOOD] = { .type = NLA_U8 },
> [IFLA_BRPORT_PROXYARP] = { .type = NLA_U8 },
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-23 10:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-23 0:53 [PATCH] net: bridge: remove redundant return 13145886936
2021-06-23 10:51 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®