From: Scott Branden <scott.branden@broadcom.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
"Allan W. Nielsen" <allan.nielsen@microsemi.com>,
Raju Lakkaraju <Raju.Lakkaraju@microsemi.com>,
Florian Fainelli <f.fainelli@gmail.com>,
BCM Kernel Feedback <bcm-kernel-feedback-list@broadcom.com>,
linux-kernel@vger.kernel.org,
Steve Lin <steven.lin1@broadcom.com>
Subject: Re: [PATCH 0/1] net: ethtool: add SmartNIC reset support
Date: Wed, 18 Oct 2017 12:31:28 -0700 [thread overview]
Message-ID: <e8f5b581-2613-0dda-d9cc-e826a14ee394@broadcom.com> (raw)
In-Reply-To: <20171018191639.GI15371@lunn.ch>
Hi Andrew,
On 17-10-18 12:16 PM, Andrew Lunn wrote:
>> Yes, there is also a management processor.
> O.K.
>
> Maybe it would be nice to add some more text to the commit message to
> make this clear. Define what an application processor is, and how it
> differs from a management processor. But othersize:
OK -will add more description to differentiate management processor vs.
application processor(s).
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>
> I assume you have another kernel patch to actually make use of this?
> It is normal to post the user of a new API in the same series as the
> API.
I actually wanted to get agreement that the bit define could be added to
ethtool before implementing it in driver.
If this direction approved we'll implement in driver and submit with
this patch series.
>
> Andrew
Thanks,
Scott
next prev parent reply other threads:[~2017-10-18 19:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-18 16:01 Scott Branden
2017-10-18 16:01 ` [PATCH 1/1] net: ethtool: add support for reset of AP inside NIC interface Scott Branden
2017-10-18 21:59 ` Scott Branden
2017-10-18 16:28 ` [PATCH 0/1] net: ethtool: add SmartNIC reset support Andrew Lunn
2017-10-18 16:52 ` Scott Branden
2017-10-18 19:16 ` Andrew Lunn
2017-10-18 19:31 ` Scott Branden [this message]
2017-10-18 21:30 ` Andy Gospodarek
2017-10-18 21:59 ` Scott Branden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8f5b581-2613-0dda-d9cc-e826a14ee394@broadcom.com \
--to=scott.branden@broadcom.com \
--cc=Raju.Lakkaraju@microsemi.com \
--cc=allan.nielsen@microsemi.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steven.lin1@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®