Re: [PATCH v1 02/10] ACPI: video: Fix backlight unregistration ordering

[Armin Wolf <W_Armin@gmx.de>]

Am 11.09.26 um 15:01 schrieb Rafael J. Wysocki:

> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>
> In acpi_video_dev_unregister_backlight(), the sysfs interface of the
> cooling class device may access the brightness object under the
> backlight device's ACPI companion, so that object cannot be freed
> before unregistering the cooling class device.
>
> Adjust the code to take that into account.

Ignoring the broken fixes tag already found by Andy:

Reviewed-by: Armin Wolf <W_Armin@gmx.de>

> Fixes:
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>   drivers/acpi/acpi_video.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
> index 4d6fd9f6e9ad..6cfe390411c1 100644
> --- a/drivers/acpi/acpi_video.c
> +++ b/drivers/acpi/acpi_video.c
> @@ -1825,6 +1825,12 @@ static int acpi_video_bus_register_backlight(struct acpi_video_bus *video)
>   
>   static void acpi_video_dev_unregister_backlight(struct acpi_video_device *device)
>   {
> +	if (device->cooling_dev) {
> +		sysfs_remove_link(&device->dev->dev.kobj, "thermal_cooling");
> +		sysfs_remove_link(&device->cooling_dev->device.kobj, "device");
> +		thermal_cooling_device_unregister(device->cooling_dev);
> +		device->cooling_dev = NULL;
> +	}
>   	if (device->backlight) {
>   		backlight_device_unregister(device->backlight);
>   		device->backlight = NULL;
> @@ -1834,12 +1840,6 @@ static void acpi_video_dev_unregister_backlight(struct acpi_video_device *device
>   		kfree(device->brightness);
>   		device->brightness = NULL;
>   	}
> -	if (device->cooling_dev) {
> -		sysfs_remove_link(&device->dev->dev.kobj, "thermal_cooling");
> -		sysfs_remove_link(&device->cooling_dev->device.kobj, "device");
> -		thermal_cooling_device_unregister(device->cooling_dev);
> -		device->cooling_dev = NULL;
> -	}
>   }
>   
>   static int acpi_video_bus_unregister_backlight(struct acpi_video_bus *video)