mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] drm/omap: dss: fix handling deferrals
@ 2026-11-11 21:14 Andreas Kemnade
  2026-11-12  7:43 ` Luca Ceresoli
  2026-11-12 10:25 ` Tomi Valkeinen
  0 siblings, 2 replies; 3+ messages in thread
From: Andreas Kemnade @ 2026-11-11 21:14 UTC (permalink / raw)
  To: Tomi Valkeinen, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter, Luca Ceresoli
  Cc: dri-devel, linux-omap, hns, linux-kernel, Andreas Kemnade

Forward the error given by of_drm_get_bridge_by_endpoint() if it is
EPROBE_DEFER to ensure output gets initialized later when available.

On GTA04/OMAP3 no display was found, but it appeared after doing
rmmod omapdrm ; modprobe omapdrm

Fixes: b7e9b93fc8ecf ("drm/omap: dss: don't create a panel_bridge")
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
Changes in v2:
- do not use the error goto
- Link to v1: https://patch.msgid.link/20261111-gta04-drm-regression-fix-v1-1-1de27d5ba46a@kemnade.info
---
 drivers/gpu/drm/omapdrm/dss/output.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/omapdrm/dss/output.c b/drivers/gpu/drm/omapdrm/dss/output.c
index 36d37deac8026..b5cef5093a883 100644
--- a/drivers/gpu/drm/omapdrm/dss/output.c
+++ b/drivers/gpu/drm/omapdrm/dss/output.c
@@ -24,6 +24,9 @@ int omapdss_device_init_output(struct omap_dss_device *out,
 
 	bridge = of_drm_get_bridge_by_endpoint(out->dev->of_node, out->of_port, 0);
 	if (IS_ERR(bridge)) {
+		if (PTR_ERR(bridge) == -EPROBE_DEFER)
+			return PTR_ERR(bridge);
+
 		dev_dbg(out->dev, "failed to find video sink\n");
 		return 0;
 	}

---
base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
change-id: 20261111-gta04-drm-regression-fix-f7ef51c66ed3

Best regards,
--  
Andreas Kemnade <andreas@kemnade.info>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] drm/omap: dss: fix handling deferrals
  2026-11-11 21:14 [PATCH v2] drm/omap: dss: fix handling deferrals Andreas Kemnade
@ 2026-11-12  7:43 ` Luca Ceresoli
  2026-11-12 10:25 ` Tomi Valkeinen
  1 sibling, 0 replies; 3+ messages in thread
From: Luca Ceresoli @ 2026-11-12  7:43 UTC (permalink / raw)
  To: Andreas Kemnade, Tomi Valkeinen, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
	Luca Ceresoli
  Cc: dri-devel, linux-omap, hns, linux-kernel

On Wed Nov 11, 2026 at 10:14 PM CET, Andreas Kemnade wrote:
> Forward the error given by of_drm_get_bridge_by_endpoint() if it is
> EPROBE_DEFER to ensure output gets initialized later when available.
>
> On GTA04/OMAP3 no display was found, but it appeared after doing
> rmmod omapdrm ; modprobe omapdrm
>
> Fixes: b7e9b93fc8ecf ("drm/omap: dss: don't create a panel_bridge")
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] drm/omap: dss: fix handling deferrals
  2026-11-11 21:14 [PATCH v2] drm/omap: dss: fix handling deferrals Andreas Kemnade
  2026-11-12  7:43 ` Luca Ceresoli
@ 2026-11-12 10:25 ` Tomi Valkeinen
  1 sibling, 0 replies; 3+ messages in thread
From: Tomi Valkeinen @ 2026-11-12 10:25 UTC (permalink / raw)
  To: Andreas Kemnade
  Cc: dri-devel, linux-omap, hns, linux-kernel, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter,
	Luca Ceresoli

Hi,

On 11/11/2026 23:14, Andreas Kemnade wrote:
> Forward the error given by of_drm_get_bridge_by_endpoint() if it is
> EPROBE_DEFER to ensure output gets initialized later when available.
> 
> On GTA04/OMAP3 no display was found, but it appeared after doing
> rmmod omapdrm ; modprobe omapdrm
> 
> Fixes: b7e9b93fc8ecf ("drm/omap: dss: don't create a panel_bridge")
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> Changes in v2:
> - do not use the error goto
> - Link to v1: https://patch.msgid.link/20261111-gta04-drm-regression-fix-v1-1-1de27d5ba46a@kemnade.info
> ---
>   drivers/gpu/drm/omapdrm/dss/output.c | 3 +++
>   1 file changed, 3 insertions(+)

Thanks, I'll push to drm-misc-next.

  Tomi

> diff --git a/drivers/gpu/drm/omapdrm/dss/output.c b/drivers/gpu/drm/omapdrm/dss/output.c
> index 36d37deac8026..b5cef5093a883 100644
> --- a/drivers/gpu/drm/omapdrm/dss/output.c
> +++ b/drivers/gpu/drm/omapdrm/dss/output.c
> @@ -24,6 +24,9 @@ int omapdss_device_init_output(struct omap_dss_device *out,
>   
>   	bridge = of_drm_get_bridge_by_endpoint(out->dev->of_node, out->of_port, 0);
>   	if (IS_ERR(bridge)) {
> +		if (PTR_ERR(bridge) == -EPROBE_DEFER)
> +			return PTR_ERR(bridge);
> +
>   		dev_dbg(out->dev, "failed to find video sink\n");
>   		return 0;
>   	}
> 
> ---
> base-commit: 7475ea8b58616b33c04afb976cf0fbaad9dd63fb
> change-id: 20261111-gta04-drm-regression-fix-f7ef51c66ed3
> 
> Best regards,
> --
> Andreas Kemnade <andreas@kemnade.info>
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-12 10:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-11 21:14 [PATCH v2] drm/omap: dss: fix handling deferrals Andreas Kemnade
2026-11-12  7:43 ` Luca Ceresoli
2026-11-12 10:25 ` Tomi Valkeinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®