[PATCH 1/1] ata: pata_arasan_cf: use standard DMA engine API

[PATCH 1/1] ata: pata_arasan_cf: use standard DMA engine API

[Frank.Li]

From: Frank Li <Frank.Li@nxp.com>

DMA engine consumers must not call the channel's callback function pointers
directly. Use the standard dmaengine wrapper APIs instead.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 drivers/ata/pata_arasan_cf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
index e05a4847e0371..a652a1b57338c 100644
--- a/drivers/ata/pata_arasan_cf.c
+++ b/drivers/ata/pata_arasan_cf.c
@@ -400,7 +400,7 @@ dma_xfer(struct arasan_cf_dev *acdev, dma_addr_t src, dma_addr_t dest, u32 len)
 	unsigned long flags = DMA_PREP_INTERRUPT;
 	int ret = 0;
 
-	tx = chan->device->device_prep_dma_memcpy(chan, dest, src, len, flags);
+	tx = dmaengine_prep_dma_memcpy(chan, dest, src, len, flags);
 	if (!tx) {
 		dev_err(acdev->host->dev, "device_prep_dma_memcpy failed\n");
 		return -EAGAIN;
@@ -408,7 +408,7 @@ dma_xfer(struct arasan_cf_dev *acdev, dma_addr_t src, dma_addr_t dest, u32 len)
 
 	tx->callback = dma_callback;
 	tx->callback_param = acdev;
-	cookie = tx->tx_submit(tx);
+	cookie = dmaengine_submit(tx);
 
 	ret = dma_submit_error(cookie);
 	if (ret) {
@@ -416,7 +416,7 @@ dma_xfer(struct arasan_cf_dev *acdev, dma_addr_t src, dma_addr_t dest, u32 len)
 		return ret;
 	}
 
-	chan->device->device_issue_pending(chan);
+	dma_async_issue_pending(chan);
 
 	/* Wait for DMA to complete */
 	if (!wait_for_completion_timeout(&acdev->dma_completion, TIMEOUT)) {
-- 
2.43.0

Re: [PATCH 1/1] ata: pata_arasan_cf: use standard DMA engine API

[Damien Le Moal]

On 2026/09/18 2:03, Frank.Li@oss.nxp.com wrote:
> From: Frank Li <Frank.Li@nxp.com>
> 
> DMA engine consumers must not call the channel's callback function pointers
> directly. Use the standard dmaengine wrapper APIs instead.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Looks good.

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH 1/1] ata: pata_arasan_cf: use standard DMA engine API

[Niklas Cassel]

On Thu, 17 Sep 2026 15:03:14 -0400, Frank.Li@oss.nxp.com wrote:
> DMA engine consumers must not call the channel's callback function pointers
> directly. Use the standard dmaengine wrapper APIs instead.
> 
> 

Applied to libata/linux.git (for-7.4), thanks!

[1/1] ata: pata_arasan_cf: use standard DMA engine API
      https://git.kernel.org/libata/linux/c/a51e0770

Kind regards,
Niklas