* [PATCH] drm/amd/display: remove unreachable code
@ 2022-08-12 3:19 Jiapeng Chong
2022-08-12 17:36 ` Tales Lelo da Aparecida
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2022-08-12 3:19 UTC (permalink / raw)
To: alexander.deucher
Cc: christian.koenig, Xinhui.Pan, airlied, daniel, amd-gfx,
dri-devel, linux-kernel, Jiapeng Chong, Abaci Robot
drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:1658 dml32_TruncToValidBPP() warn: ignoring unreachable code.
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1894
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
.../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
index 05fc14a47fba..0758e1da55a9 100644
--- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
+++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
@@ -1654,10 +1654,6 @@ double dml32_TruncToValidBPP(
else
return DesiredBPP;
}
-
- *RequiredSlots = dml_ceil(DesiredBPP / MaxLinkBPP * 64, 1);
-
- return BPP_INVALID;
} // TruncToValidBPP
double dml32_RequiredDTBCLK(
--
2.20.1.7.g153144c
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amd/display: remove unreachable code
2022-08-12 3:19 [PATCH] drm/amd/display: remove unreachable code Jiapeng Chong
@ 2022-08-12 17:36 ` Tales Lelo da Aparecida
0 siblings, 0 replies; 2+ messages in thread
From: Tales Lelo da Aparecida @ 2022-08-12 17:36 UTC (permalink / raw)
To: Jiapeng Chong
Cc: airlied, Xinhui.Pan, Abaci Robot, linux-kernel, dri-devel,
amd-gfx, daniel, christian.koenig, alexander.deucher
Hi,
On 12/08/2022 00:19, Jiapeng Chong wrote:
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn32/display_mode_vba_util_32.c:1658 dml32_TruncToValidBPP() warn: ignoring unreachable code.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=1894
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> .../drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> index 05fc14a47fba..0758e1da55a9 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn32/display_mode_vba_util_32.c
> @@ -1654,10 +1654,6 @@ double dml32_TruncToValidBPP(
> else
> return DesiredBPP;
> }
> -
> - *RequiredSlots = dml_ceil(DesiredBPP / MaxLinkBPP * 64, 1);
> -
> - return BPP_INVALID;
> } // TruncToValidBPP
>
> double dml32_RequiredDTBCLK(
Seems correct.
Reviewed-by: Tales Aparecida <tales.aparecida@gmail.com>
I feel like RequiredSlots is not actually used anywhere in the code,
just passed around dml32_TruncToValidBPP() and
dml32_CalculateOutputLink(). I've looked for any mentions of it in the
mailing list, but could not find anything that implied it's part of
ground working. I wonder if it's something outside the Linux tree for
other platforms or related to HW gospel.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-12 17:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-12 3:19 [PATCH] drm/amd/display: remove unreachable code Jiapeng Chong
2022-08-12 17:36 ` Tales Lelo da Aparecida
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®