mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Deepti Jaggi <quic_djaggi@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	<andersson@kernel.org>, <konradybcio@kernel.org>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <quic_ptalari@quicinc.com>,
	<quic_psodagud@quicinc.com>, <quic_shazhuss@quicinc.com>
Subject: Re: [PATCH v3] dt-bindings: arm: qcom: add SA8255p Ride board
Date: Thu, 24 Apr 2025 22:19:29 -0700	[thread overview]
Message-ID: <e98d181a-f7d1-45b7-afa2-fa31563e8db7@quicinc.com> (raw)
In-Reply-To: <121d4e01-00cd-4be5-acbb-b140188048c3@linaro.org>



On 4/23/25 23:17, Krzysztof Kozlowski wrote:
> On 24/04/2025 01:54, Deepti Jaggi wrote:
>>
>> On 4/23/25 05:00, Krzysztof Kozlowski wrote:
>>> On 23/04/2025 02:38, Deepti Jaggi wrote:
>>>> From: Nikunj Kela <quic_nkela@quicinc.com>
>>>>
>>>> Document the SA8255p SoC and its reference board: sa8255p-ride.
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>> Signed-off-by: Nikunj Kela <quic_nkela@quicinc.com>
>>>> Signed-off-by: Deepti Jaggi <quic_djaggi@quicinc.com>
>>>> ---
>>>> Changes in v3:
>>>> 	Removed the patches from original series[1]
>>>
>>> Why? This makes no sense on its own. Binding goes with the user. No
>>> user? No binding.
>>
>> Thanks for taking the time to review the patch.
>> All the bindings that were initially included in the original series [1]
>> were removed and posted as individual patches.
>> devicetree has been posted as a separate patch :
>> Link: https://lore.kernel.org/all/20250422231249.871995-1-quic_djaggi@quicinc.com
>> If necessary, I can consolidate the bindings and dt into a single series
>> for the next version.
> I asked why and that's not the answer to why. That's description of what
> you did, but we see it here. Anyway, I explained you the process.

By examining other patches that were split from the series by the author, 
it appears that it was advised to split the patches based on subsystem.
However, I do not have any further details.

I followed the approach used for other bindings [1] [2] [3], which were part
of the original series and were sent as separate patches and accepted.
I misjudged that the SoC binding could also be sent as a 
separate patch. I will combine the remaining bindings along with 
the device tree (DT) into a single series in the next revision.

[1]: https://lore.kernel.org/all/20240910165926.2408630-1-quic_nkela@quicinc.com/ 
[2]: https://lore.kernel.org/all/20240910171534.2412263-1-quic_nkela@quicinc.com/ 
[3]: https://lore.kernel.org/all/20240905194741.3803345-1-quic_nkela@quicinc.com/ 

> 
> Best regards,
> Krzysztof

      reply	other threads:[~2025-04-25  5:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23  0:38 Deepti Jaggi
2025-04-23 12:00 ` Krzysztof Kozlowski
2025-04-23 23:54   ` Deepti Jaggi
2025-04-24  6:17     ` Krzysztof Kozlowski
2025-04-25  5:19       ` Deepti Jaggi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e98d181a-f7d1-45b7-afa2-fa31563e8db7@quicinc.com \
    --to=quic_djaggi@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_psodagud@quicinc.com \
    --cc=quic_ptalari@quicinc.com \
    --cc=quic_shazhuss@quicinc.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®