mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] watchdog: bcm2835: add newline to dev_info message
@ 2026-11-22  8:29 Artem Novak
  2026-11-22 10:08 ` Guenter Roeck
  2026-11-22 10:23 ` [PATCH v2] " Artem Novak
  0 siblings, 2 replies; 4+ messages in thread
From: Artem Novak @ 2026-11-22  8:29 UTC (permalink / raw)
  To: wim
  Cc: linux, florian.fainelli, bcm-kernel-feedback-list,
	linux-watchdog, linux-rpi-kernel, linux-arm-kernel, linux-kernel,
	Artem Novak

Signed-off-by: Artem Novak <artem122novak@gmail.com>
---
 drivers/watchdog/bcm2835_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c
index 755954cbadee..df08236d2689 100644
--- a/drivers/watchdog/bcm2835_wdt.c
+++ b/drivers/watchdog/bcm2835_wdt.c
@@ -213,7 +213,7 @@ static int bcm2835_wdt_probe(struct platform_device *pdev)
 					      SYS_OFF_PRIO_DEFAULT,
 					      bcm2835_power_off, wdt);
 
-	dev_info(dev, "Broadcom BCM2835 watchdog timer");
+	dev_info(dev, "Broadcom BCM2835 watchdog timer\n");
 	return 0;
 }
 
-- 
2.56.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] watchdog: bcm2835: add newline to dev_info message
  2026-11-22  8:29 [PATCH] watchdog: bcm2835: add newline to dev_info message Artem Novak
@ 2026-11-22 10:08 ` Guenter Roeck
  2026-11-22 10:23 ` [PATCH v2] " Artem Novak
  1 sibling, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2026-11-22 10:08 UTC (permalink / raw)
  To: Artem Novak
  Cc: wim, florian.fainelli, bcm-kernel-feedback-list, linux-watchdog,
	linux-rpi-kernel, linux-arm-kernel, linux-kernel

On Sun, Nov 22, 2026 at 02:29:43AM -0600, Artem Novak wrote:
> Signed-off-by: Artem Novak <artem122novak@gmail.com>

Checkpatch says:

WARNING: Missing commit description - Add an appropriate one

Guenter

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] watchdog: bcm2835: add newline to dev_info message
  2026-11-22  8:29 [PATCH] watchdog: bcm2835: add newline to dev_info message Artem Novak
  2026-11-22 10:08 ` Guenter Roeck
@ 2026-11-22 10:23 ` Artem Novak
  2026-11-22 16:15   ` Guenter Roeck
  1 sibling, 1 reply; 4+ messages in thread
From: Artem Novak @ 2026-11-22 10:23 UTC (permalink / raw)
  To: linux
  Cc: artem122novak, bcm-kernel-feedback-list, florian.fainelli,
	linux-arm-kernel, linux-kernel, linux-rpi-kernel, linux-watchdog,
	wim

Add a newline to the watchdog timer initialization message so that
the message is properly terminated in the kernel log.

Signed-off-by: Artem Novak <artem122novak@gmail.com>
---
 drivers/watchdog/bcm2835_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c
index 755954cbadee..df08236d2689 100644
--- a/drivers/watchdog/bcm2835_wdt.c
+++ b/drivers/watchdog/bcm2835_wdt.c
@@ -213,7 +213,7 @@ static int bcm2835_wdt_probe(struct platform_device *pdev)
 					      SYS_OFF_PRIO_DEFAULT,
 					      bcm2835_power_off, wdt);
 
-	dev_info(dev, "Broadcom BCM2835 watchdog timer");
+	dev_info(dev, "Broadcom BCM2835 watchdog timer\n");
 	return 0;
 }
 
-- 
2.56.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] watchdog: bcm2835: add newline to dev_info message
  2026-11-22 10:23 ` [PATCH v2] " Artem Novak
@ 2026-11-22 16:15   ` Guenter Roeck
  0 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2026-11-22 16:15 UTC (permalink / raw)
  To: Artem Novak
  Cc: bcm-kernel-feedback-list, florian.fainelli, linux-arm-kernel,
	linux-kernel, linux-rpi-kernel, linux-watchdog, wim

On Sun, Nov 22, 2026 at 04:23:28AM -0600, Artem Novak wrote:
> Add a newline to the watchdog timer initialization message so that
> the message is properly terminated in the kernel log.
> 
> Signed-off-by: Artem Novak <artem122novak@gmail.com>

Applied.

> ---

For future patches: Change log goes here.

Thanks,
Guenter

>  drivers/watchdog/bcm2835_wdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/watchdog/bcm2835_wdt.c b/drivers/watchdog/bcm2835_wdt.c
> index 755954cbadee..df08236d2689 100644
> --- a/drivers/watchdog/bcm2835_wdt.c
> +++ b/drivers/watchdog/bcm2835_wdt.c
> @@ -213,7 +213,7 @@ static int bcm2835_wdt_probe(struct platform_device *pdev)
>  					      SYS_OFF_PRIO_DEFAULT,
>  					      bcm2835_power_off, wdt);
>  
> -	dev_info(dev, "Broadcom BCM2835 watchdog timer");
> +	dev_info(dev, "Broadcom BCM2835 watchdog timer\n");
>  	return 0;
>  }
>  

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-11-22 16:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-22  8:29 [PATCH] watchdog: bcm2835: add newline to dev_info message Artem Novak
2026-11-22 10:08 ` Guenter Roeck
2026-11-22 10:23 ` [PATCH v2] " Artem Novak
2026-11-22 16:15   ` Guenter Roeck

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®