From: Hao Jia <jiahao.os@bytedance.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: mingo@redhat.com, mingo@kernel.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com,
mgorman@techsingularity.net, linux-kernel@vger.kernel.org
Subject: Re: [External] Re: [PATCH 0/2] Optimize the process of scanning CPU for some functions
Date: Mon, 24 Oct 2022 21:01:00 +0800 [thread overview]
Message-ID: <e9bb46e4-c8d3-d5a0-9bed-27eccc2ea2ab@bytedance.com> (raw)
In-Reply-To: <Y1ZiKz1rxEcQ886D@hirez.programming.kicks-ass.net>
On 2022/10/24 Peter Zijlstra wrote:
> On Fri, Oct 21, 2022 at 02:15:56PM +0800, Hao Jia wrote:
>> These two patches optimize the process of scanning the CPU by
>> adjusting the search order or breaking the loop.
>
> Is it really optimization, as in it now runs measurably faster, or just
> cleanups?
I'm very sorry that my description confused you.
Yes, these two patches should just be cleanups.
Reduce the number of attempts by adjusting the scan order or breaking
the loop in time.
IMHO, it will lead to a little optimization in most cases.
But they won't bring significant performance gains. So, it's just cleanups.
Thanks,
Hao
prev parent reply other threads:[~2022-10-24 14:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 6:15 Hao Jia
2022-10-21 6:15 ` [PATCH 1/2] sched/numa: Stop an exhastive search if an idle core is found Hao Jia
2022-10-24 13:34 ` Mel Gorman
2022-10-25 3:16 ` [External] " Hao Jia
2022-10-25 9:32 ` Mel Gorman
2022-10-25 11:10 ` Hao Jia
2022-10-25 13:32 ` Mel Gorman
2022-10-26 2:30 ` Hao Jia
2022-10-21 6:15 ` [PATCH 2/2] sched/core: Optimize the order of scanning CPU Hao Jia
2022-10-24 10:00 ` [PATCH 0/2] Optimize the process of scanning CPU for some functions Peter Zijlstra
2022-10-24 12:07 ` [External] " Hao Jia
2022-10-24 13:01 ` Hao Jia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9bb46e4-c8d3-d5a0-9bed-27eccc2ea2ab@bytedance.com \
--to=jiahao.os@bytedance.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mgorman@techsingularity.net \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome