* [PATCH] tools/power/x86/intel-speed-select: Support more than 8 sockets.
@ 2023-07-20 16:08 Frank Ramsay
2023-07-20 16:46 ` srinivas pandruvada
0 siblings, 1 reply; 2+ messages in thread
From: Frank Ramsay @ 2023-07-20 16:08 UTC (permalink / raw)
To: Frank Ramsay, Dimitri Sivanich, Russ Anderson,
Srinivas Pandruvada, platform-driver-x86, linux-kernel
MAX_PACKAGE_COUNT limits the intel-speed-select to systems with 8 sockets or fewer.
On a system with more than 8 sockets intel-speed-select silently ignores everything
beyond the 8th socket, rendering the tool useless for those systems.
Increase MAX_PACKAGE_COUNT to support systems with up to 32 sockets.
Signed-off-by: Frank Ramsay <frank.ramsay@hpe.com>
---
tools/power/x86/intel-speed-select/isst.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/power/x86/intel-speed-select/isst.h b/tools/power/x86/intel-speed-select/isst.h
index 54fc21575d56..8def22dec4a2 100644
--- a/tools/power/x86/intel-speed-select/isst.h
+++ b/tools/power/x86/intel-speed-select/isst.h
@@ -79,7 +79,7 @@
#define DISP_FREQ_MULTIPLIER 100
-#define MAX_PACKAGE_COUNT 8
+#define MAX_PACKAGE_COUNT 32
#define MAX_DIE_PER_PACKAGE 2
#define MAX_PUNIT_PER_DIE 8
--
2.39.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tools/power/x86/intel-speed-select: Support more than 8 sockets.
2023-07-20 16:08 [PATCH] tools/power/x86/intel-speed-select: Support more than 8 sockets Frank Ramsay
@ 2023-07-20 16:46 ` srinivas pandruvada
0 siblings, 0 replies; 2+ messages in thread
From: srinivas pandruvada @ 2023-07-20 16:46 UTC (permalink / raw)
To: Frank Ramsay, Dimitri Sivanich, Russ Anderson,
platform-driver-x86, linux-kernel
On Thu, 2023-07-20 at 11:08 -0500, Frank Ramsay wrote:
> MAX_PACKAGE_COUNT limits the intel-speed-select to systems with 8
> sockets or fewer.
> On a system with more than 8 sockets intel-speed-select silently
> ignores everything
> beyond the 8th socket, rendering the tool useless for those systems.
>
> Increase MAX_PACKAGE_COUNT to support systems with up to 32 sockets.
>
Thanks for the patch. I will queue this for the next release.
-Srinivas
> Signed-off-by: Frank Ramsay <frank.ramsay@hpe.com>
> ---
> tools/power/x86/intel-speed-select/isst.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/x86/intel-speed-select/isst.h
> b/tools/power/x86/intel-speed-select/isst.h
> index 54fc21575d56..8def22dec4a2 100644
> --- a/tools/power/x86/intel-speed-select/isst.h
> +++ b/tools/power/x86/intel-speed-select/isst.h
> @@ -79,7 +79,7 @@
>
> #define DISP_FREQ_MULTIPLIER 100
>
> -#define MAX_PACKAGE_COUNT 8
> +#define MAX_PACKAGE_COUNT 32
> #define MAX_DIE_PER_PACKAGE 2
> #define MAX_PUNIT_PER_DIE 8
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-20 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-20 16:08 [PATCH] tools/power/x86/intel-speed-select: Support more than 8 sockets Frank Ramsay
2023-07-20 16:46 ` srinivas pandruvada
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome