Re: [PATCH RESEND v2] drm/amdgpu: Fix kernel-doc comments for some LUT properties

[Alex Hung <alex.hung@amd.com>]

Applied. Thanks for the fixes.


On 3/5/26 11:00, Melissa Wen wrote:
> + cc: Alex Hung
> 
> Hi Alex H.,
> 
> Can you apply this patch?
> 
> Thanks,
> 
> Melissa
> 
> On 05/03/2026 08:16, Cristian Ciocaltea wrote:
>> The following members of struct amdgpu_mode_info do not have valid
>> references in the related kernel-doc sections:
>>
>>   - plane_shaper_lut_property
>>   - plane_shaper_lut_size_property,
>>   - plane_lut3d_size_property
>>
>> Correct all affected comment blocks.
>>
>> Fixes: f545d82479b4 ("drm/amd/display: add plane shaper LUT and TF 
>> driver-specific properties")
>> Fixes: 671994e3bf33 ("drm/amd/display: add plane 3D LUT driver- 
>> specific properties")
>> Reviewed-by: Melissa Wen <mwen@igalia.com>
>> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
>> ---
>> Changes in v2:
>> - Collected R-b tag from Melissa
>> - Rebased onto latest drm-misc-next
>> - Link to v1: https://lore.kernel.org/r/20250823-amdgpu-fix-kdoc-lut- 
>> v1-1-306bcad41267@collabora.com
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h | 16 ++++++++--------
>>   1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h b/drivers/gpu/ 
>> drm/amd/amdgpu/amdgpu_mode.h
>> index dc8d2f52c7d6..e244c12ceb23 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h
>> @@ -368,15 +368,15 @@ struct amdgpu_mode_info {
>>       struct drm_property *plane_ctm_property;
>>       /**
>> -     * @shaper_lut_property: Plane property to set pre-blending 
>> shaper LUT
>> -     * that converts color content before 3D LUT. If
>> -     * plane_shaper_tf_property != Identity TF, AMD color module will
>> +     * @plane_shaper_lut_property: Plane property to set pre-blending
>> +     * shaper LUT that converts color content before 3D LUT.
>> +     * If plane_shaper_tf_property != Identity TF, AMD color module will
>>        * combine the user LUT values with pre-defined TF into the LUT
>>        * parameters to be programmed.
>>        */
>>       struct drm_property *plane_shaper_lut_property;
>>       /**
>> -     * @shaper_lut_size_property: Plane property for the size of
>> +     * @plane_shaper_lut_size_property: Plane property for the size of
>>        * pre-blending shaper LUT as supported by the driver (read-only).
>>        */
>>       struct drm_property *plane_shaper_lut_size_property;
>> @@ -400,10 +400,10 @@ struct amdgpu_mode_info {
>>        */
>>       struct drm_property *plane_lut3d_property;
>>       /**
>> -     * @plane_degamma_lut_size_property: Plane property to define the 
>> max
>> -     * size of 3D LUT as supported by the driver (read-only). The max 
>> size
>> -     * is the max size of one dimension and, therefore, the max 
>> number of
>> -     * entries for 3D LUT array is the 3D LUT size cubed;
>> +     * @plane_lut3d_size_property: Plane property to define the max size
>> +     * of 3D LUT as supported by the driver (read-only). The max size is
>> +     * the max size of one dimension and, therefore, the max number of
>> +     * entries for 3D LUT array is the 3D LUT size cubed.
>>        */
>>       struct drm_property *plane_lut3d_size_property;
>>       /**
>>
>> ---
>> base-commit: be4cd2a13a31496c7fb9e46a244c4391b8b7cf31
>> change-id: 20250823-amdgpu-fix-kdoc-lut-357db8b57fee
>