mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4 v9] i.MX31: framebuffer driver
Date: Wed, 25 Feb 2009 14:54:48 -0700	[thread overview]
Message-ID: <e9c3a7c20902251354x5512c222h41c2c9ebfa290e0b@mail.gmail.com> (raw)
In-Reply-To: <1235068604.18650.16.camel@dwillia2-linux.ch.intel.com>

On Thu, Feb 19, 2009 at 11:36 AM, Dan Williams <dan.j.williams@intel.com> wrote:
> On Thu, 2009-02-19 at 07:41 -0700, Guennadi Liakhovetski wrote:
>> Please, oh, please, wake me up if I'm dreaming... In the patch below all
>> the indentation in _both_ mx3fb.h and mx3fb.c is with TABs (ok, didn't
>> check all, a couple). Nun im Linus' git-tree - _ALL_ (that I checked)
>> indentation is with... BLANKS!!!??? Could someone, please, tell me what
>> was in that cup of tee I've drunk an hour ago?... Dan, you pushed this
>> patch via your tree, right? Could you double-check, please?
>>
>
> What a mess.  The other patches in your series were applied and
> checkpatched from the tarball you sent.  This last fix up patch was not
> cc'd to lkml so I fell back to applying it from a saved Thunderbird
> message.  The real issue is that I did not have checkpatch automated
> from StackedGIT's import command.  Please double check the fix below...
>

Sascha,

Will you be taking this clean-up through your tree?  I don't think it
is suitable for 2.6.29 and in my opinion it belongs with other IMX
platform driver fixups targeted for 2.6.30.

Thoughts?

--
Dan

  reply	other threads:[~2009-02-25 21:55 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-26 17:11 [PATCH 0/4 v6] i.MX31: dmaengine and framebuffer drivers Guennadi Liakhovetski
2008-12-26 17:11 ` [PATCH 1/4 v6] dmaengine: add async_tx_clear_ack() macro Guennadi Liakhovetski
2008-12-26 17:11 ` [PATCH 2/4 v6] i.MX31: Image Processing Unit DMA and IRQ drivers Guennadi Liakhovetski
2008-12-26 17:11 ` [PATCH 3/4 v6] i.MX31: framebuffer driver Guennadi Liakhovetski
2008-12-26 17:11 ` [PATCH 4/4 v6] i.MX31: platform bindings and initialisation for IPU and framebuffer drivers Guennadi Liakhovetski
2009-01-05 19:43 ` [PATCH 0/4 v6] i.MX31: dmaengine " Dan Williams
2009-01-05 21:02   ` Guennadi Liakhovetski
2009-01-05 21:35     ` Dan Williams
2009-01-16 10:09   ` Guennadi Liakhovetski
2009-01-16 17:39     ` Dan Williams
     [not found]       ` <Pine.LNX.4.64.0901162048400.9060@axis700.grange>
     [not found]         ` <4974F208.3020407@intel.com>
     [not found]           ` <Pine.LNX.4.64.0901201048090.5126@axis700.grange>
2009-02-19 14:41             ` [PATCH 3/4 v9] i.MX31: framebuffer driver Guennadi Liakhovetski
2009-02-19 18:36               ` Dan Williams
2009-02-25 21:54                 ` Dan Williams [this message]
2009-02-26  7:37                   ` Guennadi Liakhovetski
2009-02-26 18:41                     ` Dan Williams
2009-02-26 20:34                       ` Guennadi Liakhovetski
2009-02-27  0:36                         ` Dan Williams
2009-01-06  9:04 ` [PATCH 0/4 v6] i.MX31: dmaengine and framebuffer drivers Sascha Hauer
2009-01-06  9:51   ` Guennadi Liakhovetski
2009-01-06 10:19     ` Sascha Hauer
2009-01-06 13:20       ` Hans J. Koch
2009-01-08 11:15         ` [PATCH 2/4 v7] i.MX31: Image Processing Unit DMA and IRQ drivers Guennadi Liakhovetski
2009-01-08 10:50 ` [PATCH 0/4 v6] i.MX31: dmaengine and framebuffer drivers Sascha Hauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9c3a7c20902251354x5512c222h41c2c9ebfa290e0b@mail.gmail.com \
    --to=dan.j.williams@intel.com \
    --cc=g.liakhovetski@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®