From: Krzysztof Kozlowski <krzk@kernel.org>
To: xie.ludan@zte.com.cn, bentiss@kernel.org
Cc: jikos@kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, xu.xin16@zte.com.cn,
yang.yang29@zte.com.cn, jiang.peng9@zte.com.cn
Subject: Re: [PATCH] HID: appletb-kbd: Replace msecs_to_jiffies with secs_to_jiffies for timer settings
Date: Wed, 19 Mar 2025 08:26:48 +0100 [thread overview]
Message-ID: <e9c3eca1-5dc9-46e1-a356-87643434cee0@kernel.org> (raw)
In-Reply-To: <20250319101242304iR6PbYo3hAvFto8weR2Ps@zte.com.cn>
On 19/03/2025 03:12, xie.ludan@zte.com.cn wrote:
> From: Peng Jiang <jiang.peng9@zte.com.cn>
>
> The variables `appletb_tb_idle_timeout` and `appletb_tb_dim_timeout`
> are already defined in seconds, so using `secs_to_jiffies` directly
> makes the code more readable and consistent with the units used.
>
> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
> the following Coccinelle rules:
Why do you need to paste here contentx of existing cocci script? It's
already mainlined, no?
>
> @depends on patch@
> expression E;
> @@
>
> -msecs_to_jiffies
> +secs_to_jiffies
> (E
> - * \( 1000 \| MSEC_PER_SEC \)
> )
>
> Signed-off-by: Peng Jiang <jiang.peng9@zte.com.cn>
> Signed-off-by: XieLudan <xie.ludan@zte.com.cn>
Same comment as before. Did you respond to previous feedbacks? No.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-19 7:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 2:12 xie.ludan
2025-03-19 7:26 ` Krzysztof Kozlowski [this message]
2025-03-19 8:01 ` jiang.peng9
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9c3eca1-5dc9-46e1-a356-87643434cee0@kernel.org \
--to=krzk@kernel.org \
--cc=bentiss@kernel.org \
--cc=jiang.peng9@zte.com.cn \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xie.ludan@zte.com.cn \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®