From: Andrew Lunn <andrew@lunn.ch>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Biju Das <biju.das.jz@bp.renesas.com>,
Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH net-next v2 3/3] net: phy: mscc: Add support for PHY LED control
Date: Tue, 11 Nov 2025 03:53:30 +0100 [thread overview]
Message-ID: <e9e7c43c-a58d-4b7a-957b-5d58ff24fbd4@lunn.ch> (raw)
In-Reply-To: <20251107201232.282152-4-prabhakar.mahadev-lad.rj@bp.renesas.com>
On Fri, Nov 07, 2025 at 08:12:32PM +0000, Prabhakar wrote:
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
>
> Add support for the PHY LED controller in the MSCC VSC85xx driver. The
> implementation provides LED brightness and hardware control through the
> LED subsystem and integrates with the standard 'netdev' trigger.
>
> Introduce new register definitions for the LED behavior register
> (MSCC_PHY_LED_BEHAVIOR = 30) and the LED combine disable bits, which
> control whether LEDs indicate link-only or combined link and activity
> status. Implement a helper, vsc8541_led_combine_disable_set(), to update
> these bits safely using phy_modify().
>
> Add support for LED brightness control and hardware mode configuration.
> The new callbacks implement the standard LED class operations, allowing
> user control through sysfs. The brightness control maps to PHY LED force
> on/off modes. The hardware control get and set functions translate
> between the PHY-specific LED mode encodings and the LED subsystem
> TRIGGER_NETDEV_* rules.
>
> The combine feature is managed automatically based on the selected
> rules. When both RX and TX activity are disabled, the combine feature is
> turned off, causing LEDs to indicate link-only status. When either RX or
> TX activity is enabled, the combine feature remains active and LEDs
> indicate combined link and activity.
>
> Register the LED callbacks for all VSC85xx PHY variants so that the LED
> subsystem can manage their indicators consistently. Existing device tree
> LED configuration and default behavior are preserved.
>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
prev parent reply other threads:[~2025-11-11 2:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-07 20:12 [PATCH net-next v2 0/3] " Prabhakar
2025-11-07 20:12 ` [PATCH net-next v2 1/3] net: phy: mscc: Simplify LED mode update using phy_modify() Prabhakar
2025-11-11 2:40 ` Andrew Lunn
2025-11-07 20:12 ` [PATCH net-next v2 2/3] net: phy: mscc: Consolidate probe functions into a common helper Prabhakar
2025-11-11 2:50 ` Andrew Lunn
2025-11-11 8:50 ` Lad, Prabhakar
2025-11-07 20:12 ` [PATCH net-next v2 3/3] net: phy: mscc: Add support for PHY LED control Prabhakar
2025-11-11 2:53 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9e7c43c-a58d-4b7a-957b-5d58ff24fbd4@lunn.ch \
--to=andrew@lunn.ch \
--cc=biju.das.jz@bp.renesas.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fabrizio.castro.jz@renesas.com \
--cc=geert+renesas@glider.be \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®