mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Prabhakar <prabhakar.csengg@gmail.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	Maxime Chevallier <maxime.chevallier@bootlin.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	Biju Das <biju.das.jz@bp.renesas.com>,
	Fabrizio Castro <fabrizio.castro.jz@renesas.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH net-next v2 2/3] net: phy: mscc: Consolidate probe functions into a common helper
Date: Tue, 11 Nov 2025 03:50:11 +0100	[thread overview]
Message-ID: <ec28d950-f7ef-4708-88aa-58c2b9b0b92a@lunn.ch> (raw)
In-Reply-To: <20251107201232.282152-3-prabhakar.mahadev-lad.rj@bp.renesas.com>

diff(1) has not made this easy...

> +static int vsc85xx_probe_common(struct phy_device *phydev,
> +				const struct vsc85xx_probe_config *cfg,
> +				const u32 *default_led_mode)
> +	int ret;

> +	/* Check rate magic if needed (only for non-package PHYs) */
> +	if (cfg->check_rate_magic) {
> +		ret = vsc85xx_edge_rate_magic_get(phydev);
> +		if (ret < 0)
> +			return ret;
> +	}
>  
>  	vsc8531 = devm_kzalloc(&phydev->mdio.dev, sizeof(*vsc8531), GFP_KERNEL);
>  	if (!vsc8531)
> 		return -ENOMEM;

> +	/* Store rate magic if it was checked */
> +	if (cfg->check_rate_magic)
> +		vsc8531->rate_magic = ret;


I think we end up with something like the above?

I would move the vsc85xx_edge_rate_magic_get() after kzalloc() just to
keep it all together.

    Andrew

---
pw-bot: cr


  reply	other threads:[~2025-11-11  2:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-07 20:12 [PATCH net-next v2 0/3] net: phy: mscc: Add support for PHY LED control Prabhakar
2025-11-07 20:12 ` [PATCH net-next v2 1/3] net: phy: mscc: Simplify LED mode update using phy_modify() Prabhakar
2025-11-11  2:40   ` Andrew Lunn
2025-11-07 20:12 ` [PATCH net-next v2 2/3] net: phy: mscc: Consolidate probe functions into a common helper Prabhakar
2025-11-11  2:50   ` Andrew Lunn [this message]
2025-11-11  8:50     ` Lad, Prabhakar
2025-11-07 20:12 ` [PATCH net-next v2 3/3] net: phy: mscc: Add support for PHY LED control Prabhakar
2025-11-11  2:53   ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec28d950-f7ef-4708-88aa-58c2b9b0b92a@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fabrizio.castro.jz@renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=hkallweit1@gmail.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=maxime.chevallier@bootlin.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=prabhakar.csengg@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=vadim.fedorenko@linux.dev \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®