mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86: fix missing declartion of init_fs
@ 2024-11-25 12:30 Zhang Kunbo
  2024-11-25 21:04 ` Markus Elfring
  0 siblings, 1 reply; 2+ messages in thread
From: Zhang Kunbo @ 2024-11-25 12:30 UTC (permalink / raw)
  To: viro, brauner, jack; +Cc: linux-fsdevel, linux-kernel, liaochang1, chris.zjh

fs/fs_struct.c should include include/linux/init_task.h
 for declaration of init_fs. This fix the sparse warning:

fs/fs_struct.c:163:18: warning: symbol 'init_fs' was not declared. Should it be static?

Signed-off-by: Zhang Kunbo <zhangkunbo@huawei.com>
---
 fs/fs_struct.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fs/fs_struct.c b/fs/fs_struct.c
index 64c2d0814ed6..100bd3474476 100644
--- a/fs/fs_struct.c
+++ b/fs/fs_struct.c
@@ -6,6 +6,7 @@
 #include <linux/path.h>
 #include <linux/slab.h>
 #include <linux/fs_struct.h>
+#include <linux/init_task.h>
 #include "internal.h"
 
 /*
-- 
2.34.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] x86: fix missing declartion of init_fs
  2024-11-25 12:30 [PATCH] x86: fix missing declartion of init_fs Zhang Kunbo
@ 2024-11-25 21:04 ` Markus Elfring
  0 siblings, 0 replies; 2+ messages in thread
From: Markus Elfring @ 2024-11-25 21:04 UTC (permalink / raw)
  To: Zhang Kunbo, linux-fsdevel, Alexander Viro, Christian Brauner, Jan Kara
  Cc: LKML, Liao Chang, Zhang Jianhua

> fs/fs_struct.c should include include/linux/init_task.h
>  for declaration of init_fs. This fix the sparse warning:
…

Please avoid a typo in the summary phrase accordingly.


See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12#n94

Regards,
Markus

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-25 21:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-25 12:30 [PATCH] x86: fix missing declartion of init_fs Zhang Kunbo
2024-11-25 21:04 ` Markus Elfring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®