mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: stm32: rename LEDs nodes for stm32f769-disco
@ 2025-02-17 11:45 Dario Binacchi
  2025-02-17 11:45 ` [PATCH 2/2] ARM: dts: stm32: add usr3 LED node to stm32f769-disco Dario Binacchi
  0 siblings, 1 reply; 3+ messages in thread
From: Dario Binacchi @ 2025-02-17 11:45 UTC (permalink / raw)
  To: linux-kernel
  Cc: Dario Binacchi, Alexandre Torgue, Conor Dooley,
	Krzysztof Kozlowski, Maxime Coquelin, Rob Herring, devicetree,
	linux-arm-kernel, linux-stm32

Associate the LED node name with the corresponding board silkscreen for
more precise identification. In fact, the board has a total of seven
LEDs, some of which are user-controllable (i. e. usr{1,2,3}), while
others are directly controlled by hardware (e. g. power, overcurrent,
...). All these LEDs are either green or red, so using the names
led-green and led-red for the two LEDs mapped in the DTS does not
simplify their identification on the board.

Moreover, this patch is a prerequisite for adding the usr3 LED, which
has not been included in the DTS.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 arch/arm/boot/dts/st/stm32f769-disco.dts | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts
index 52c5baf58ab9..d52e36aedcfb 100644
--- a/arch/arm/boot/dts/st/stm32f769-disco.dts
+++ b/arch/arm/boot/dts/st/stm32f769-disco.dts
@@ -79,11 +79,11 @@ aliases {
 
 	leds {
 		compatible = "gpio-leds";
-		led-green {
+		led-usr2 {
 			gpios = <&gpioj 5 GPIO_ACTIVE_HIGH>;
 			linux,default-trigger = "heartbeat";
 		};
-		led-red {
+		led-usr1 {
 			gpios = <&gpioj 13 GPIO_ACTIVE_HIGH>;
 		};
 	};
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ARM: dts: stm32: add usr3 LED node to stm32f769-disco
  2025-02-17 11:45 [PATCH 1/2] ARM: dts: stm32: rename LEDs nodes for stm32f769-disco Dario Binacchi
@ 2025-02-17 11:45 ` Dario Binacchi
  2025-02-27  8:38   ` Alexandre TORGUE
  0 siblings, 1 reply; 3+ messages in thread
From: Dario Binacchi @ 2025-02-17 11:45 UTC (permalink / raw)
  To: linux-kernel
  Cc: Dario Binacchi, Alexandre Torgue, Conor Dooley,
	Krzysztof Kozlowski, Maxime Coquelin, Rob Herring, devicetree,
	linux-arm-kernel, linux-stm32

As indicated by the board silkscreen, there are three user LEDs.
Add the missing one.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
---

 arch/arm/boot/dts/st/stm32f769-disco.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts
index d52e36aedcfb..535cfdc4681c 100644
--- a/arch/arm/boot/dts/st/stm32f769-disco.dts
+++ b/arch/arm/boot/dts/st/stm32f769-disco.dts
@@ -86,6 +86,9 @@ led-usr2 {
 		led-usr1 {
 			gpios = <&gpioj 13 GPIO_ACTIVE_HIGH>;
 		};
+		led-usr3 {
+			gpios = <&gpioa 12 GPIO_ACTIVE_HIGH>;
+		};
 	};
 
 	gpio-keys {
-- 
2.43.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] ARM: dts: stm32: add usr3 LED node to stm32f769-disco
  2025-02-17 11:45 ` [PATCH 2/2] ARM: dts: stm32: add usr3 LED node to stm32f769-disco Dario Binacchi
@ 2025-02-27  8:38   ` Alexandre TORGUE
  0 siblings, 0 replies; 3+ messages in thread
From: Alexandre TORGUE @ 2025-02-27  8:38 UTC (permalink / raw)
  To: Dario Binacchi, linux-kernel
  Cc: Conor Dooley, Krzysztof Kozlowski, Maxime Coquelin, Rob Herring,
	devicetree, linux-arm-kernel, linux-stm32



On 2/17/25 12:45, Dario Binacchi wrote:
> As indicated by the board silkscreen, there are three user LEDs.
> Add the missing one.
> 
> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> ---
> 
>   arch/arm/boot/dts/st/stm32f769-disco.dts | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/st/stm32f769-disco.dts b/arch/arm/boot/dts/st/stm32f769-disco.dts
> index d52e36aedcfb..535cfdc4681c 100644
> --- a/arch/arm/boot/dts/st/stm32f769-disco.dts
> +++ b/arch/arm/boot/dts/st/stm32f769-disco.dts
> @@ -86,6 +86,9 @@ led-usr2 {
>   		led-usr1 {
>   			gpios = <&gpioj 13 GPIO_ACTIVE_HIGH>;
>   		};
> +		led-usr3 {
> +			gpios = <&gpioa 12 GPIO_ACTIVE_HIGH>;
> +		};
>   	};
>   
>   	gpio-keys {

Series applied on stm32-next.

Thanks
Alex

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-02-27  8:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-17 11:45 [PATCH 1/2] ARM: dts: stm32: rename LEDs nodes for stm32f769-disco Dario Binacchi
2025-02-17 11:45 ` [PATCH 2/2] ARM: dts: stm32: add usr3 LED node to stm32f769-disco Dario Binacchi
2025-02-27  8:38   ` Alexandre TORGUE

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®