From: Krzysztof Kozlowski <krzk@kernel.org>
To: Nick Li <nick.li@foursemi.com>
Cc: lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org, perex@perex.cz,
tiwai@suse.com, xiaoming.yang@foursemi.com,
danyang.zheng@foursemi.com, like.xy@foxmail.com,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] ASoC: dt-bindings: Add FS2104/5S audio amplifiers
Date: Mon, 21 Jul 2025 14:15:38 +0200 [thread overview]
Message-ID: <ea2f30ff-b2cf-4b88-9fe8-78950a03d882@kernel.org> (raw)
In-Reply-To: <F04DD98A69286426+aH4sT_P0GvttoCOq@foursemi.com>
On 21/07/2025 14:02, Nick Li wrote:
> On Mon, Jul 21, 2025 at 12:48:24PM +0200, Krzysztof Kozlowski wrote:
>> On 21/07/2025 12:38, Nick wrote:
>>> + firmware-name:
>>> + maxItems: 1
>>> + description: |
>>> + The firmware(*.bin) contains:
>>> + a. Register initialization settings
>>> + b. DSP effect parameters
>>> + c. Multi-scene sound effect configurations(optional)
>>> + It's gernerated by FourSemi's tuning tool.
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - '#sound-dai-cells'
>>> + - reset-gpios
>>> + - firmware-name
>>
>>
>> I do not see how you resolved my comment from v1 or v2. Nothing in the
>> changelog explains that either.
>
> Change logs are in the cover letter:
And as I said I do not see resolution of my comment.
If you reject reviewers comment, usually it should be mentioned in the
changelog.
Otherwise you get now the same review as v1 or v2. Devices cannot work
without power.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-21 12:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 10:38 [PATCH v4 0/4] ASoC: codecs: Add support for FourSemi FS2104/5S Nick
2025-07-21 10:38 ` [PATCH v4 1/4] dt-bindings: vendor-prefixes: Add Shanghai FourSemi Semiconductor Co.,Ltd Nick
2025-07-21 10:38 ` [PATCH v4 2/4] ASoC: dt-bindings: Add FS2104/5S audio amplifiers Nick
2025-07-21 10:48 ` Krzysztof Kozlowski
2025-07-21 12:02 ` Nick Li
2025-07-21 12:15 ` Krzysztof Kozlowski [this message]
2025-07-21 12:40 ` Nick Li
2025-07-21 13:04 ` Krzysztof Kozlowski
2025-07-22 6:06 ` Nick Li
2025-07-21 10:38 ` [PATCH v4 3/4] ASoC: codecs: Add library for FourSemi " Nick
2025-07-21 10:38 ` [PATCH v4 4/4] ASoC: codecs: Add FourSemi FS2104/5S audio amplifier driver Nick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea2f30ff-b2cf-4b88-9fe8-78950a03d882@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=danyang.zheng@foursemi.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=like.xy@foxmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nick.li@foursemi.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
--cc=xiaoming.yang@foursemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®