Re: [PATCH v4 2/4] ASoC: dt-bindings: Add FS2104/5S audio amplifiers

[Krzysztof Kozlowski <krzk@kernel.org>]

On 21/07/2025 14:40, Nick Li wrote:
> On Mon, Jul 21, 2025 at 02:15:38PM +0200, Krzysztof Kozlowski wrote:
>> On 21/07/2025 14:02, Nick Li wrote:
>>> On Mon, Jul 21, 2025 at 12:48:24PM +0200, Krzysztof Kozlowski wrote:
>>>> On 21/07/2025 12:38, Nick wrote:
>>>>> +  firmware-name:
>>>>> +    maxItems: 1
>>>>> +    description: |
>>>>> +      The firmware(*.bin) contains:
>>>>> +      a. Register initialization settings
>>>>> +      b. DSP effect parameters
>>>>> +      c. Multi-scene sound effect configurations(optional)
>>>>> +      It's gernerated by FourSemi's tuning tool.
>>>>> +
>>>>> +required:
>>>>> +  - compatible
>>>>> +  - reg
>>>>> +  - '#sound-dai-cells'
>>>>> +  - reset-gpios
>>>>> +  - firmware-name
>>>>
>>>>
>>>> I do not see how you resolved my comment from v1 or v2. Nothing in the
>>>> changelog explains that either.
>>>
>>> Change logs are in the cover letter:
>>
>>
>> And as I said I do not see resolution of my comment.
>>
>> If you reject reviewers comment, usually it should be mentioned in the
>> changelog.
>>
>> Otherwise you get now the same review as v1 or v2. Devices cannot work
>> without power.
> 
> I explained it in the previous email:
> The power may be connected to the baterry/adapter directly,
> it may not be under the control of the software,
> in this case, the supplies are use as dummy regulators?

You describe here this device, not the board. Does this device needs
this to be connected to source of power? Battery is such source.

> 
> And we tested the driver without the supplies in DTS,

That's a terrible argument. If I do random changes in my bootloader like
toggle on clocks, does that mean that hardware does not need that thing
(like clocks)?

> so I didn't mark the supplies as the required items.

Changelog also did not say you did not implement the comment.

Best regards,
Krzysztof