From: Shawn Lin <shawn.lin@rock-chips.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: shawn.lin@rock-chips.com, Rob Herring <robh+dt@kernel.org>,
Huibin Hong <huibin.hong@rock-chips.com>,
Xing Zheng <zhengxing@rock-chips.com>,
devicetree@vger.kernel.org, dianders@chromium.org,
briannorris@chromium.org, Caesar Wang <wxt@rock-chips.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/3] dt/bindings: arm-pl330: add description of arm,pl330-periph-burst
Date: Fri, 5 Aug 2016 15:25:47 +0800 [thread overview]
Message-ID: <ea3572fa-4bff-87db-d5ad-f406809f8296@rock-chips.com> (raw)
In-Reply-To: <20160805033410.GJ9681@localhost>
Hi Vinod,
在 2016/8/5 11:34, Vinod Koul 写道:
> On Fri, Aug 05, 2016 at 10:53:20AM +0800, Shawn Lin wrote:
>> This patch adds the "arm,pl330-periph-burst" for arm-pl330 to
>> support busrt mode.
>
> why should this be DT property. Only reason I can think of if some hw
> versions support this and some won't.
yes, if we want to support burst mode, both of the master(pl330) and
client(several peripherals) should implement it, otherwise it will
be broken when enabling.
So I mentioned it on my cover letter as the reason to introduce this
optional property. If people add this property and find it's ok for
their platform, they could land new dt-patch to add it. But we could
*not* presume that we could get all users involved in testing this
patchet. I don't wanna to break any other platforms, so it's needed.
Thanks.
>
> If all are supporting, please enable it everywhere for obvious reasons.
>
--
Best Regards
Shawn Lin
next prev parent reply other threads:[~2016-08-05 7:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-05 2:53 [PATCH 0/3] Support burst request by peripherals Shawn Lin
2016-08-05 2:53 ` [PATCH 1/3] dt/bindings: arm-pl330: add description of arm,pl330-periph-burst Shawn Lin
2016-08-05 3:34 ` Vinod Koul
2016-08-05 7:25 ` Shawn Lin [this message]
2016-08-09 8:39 ` Lars-Peter Clausen
2016-08-09 9:12 ` Shawn Lin
2016-08-17 8:11 ` Shawn Lin
2016-08-19 2:45 ` Vinod Koul
2016-08-21 1:00 ` Shawn Lin
2016-08-22 6:04 ` Vinod Koul
2016-08-05 2:53 ` [PATCH 2/3] dmaengine: pl330: enable burst mode by parsing dt Shawn Lin
2016-08-07 9:20 ` Xing Zheng
2016-08-05 2:53 ` [PATCH 3/3] dmaengine: pl330: support transfer unaligned with (burst len * burst size) Shawn Lin
2016-08-07 9:21 ` Xing Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea3572fa-4bff-87db-d5ad-f406809f8296@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmaengine@vger.kernel.org \
--cc=huibin.hong@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vinod.koul@intel.com \
--cc=wxt@rock-chips.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®