mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <Mario.Limonciello@dell.com>
To: <greg@kroah.com>
Cc: <dvhart@infradead.org>, <andy.shevchenko@gmail.com>,
	<linux-kernel@vger.kernel.org>,
	<platform-driver-x86@vger.kernel.org>, <luto@kernel.org>,
	<quasisec@google.com>, <pali.rohar@gmail.com>,
	<rjw@rjwysocki.net>, <mjg59@google.com>, <hch@lst.de>
Subject: RE: [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface
Date: Tue, 10 Oct 2017 14:17:48 +0000	[thread overview]
Message-ID: <ea5e28972c5a485f988256de5e4e7289@ausx13mpc120.AMER.DELL.COM> (raw)
In-Reply-To: <20171010135920.GD8662@kroah.com>



> -----Original Message-----
> From: Greg KH [mailto:greg@kroah.com]
> Sent: Tuesday, October 10, 2017 8:59 AM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: dvhart@infradead.org; Andy Shevchenko <andy.shevchenko@gmail.com>;
> LKML <linux-kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org;
> Andy Lutomirski <luto@kernel.org>; quasisec@google.com;
> pali.rohar@gmail.com; rjw@rjwysocki.net; mjg59@google.com; hch@lst.de
> Subject: Re: [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce
> userspace interface
> 
> On Mon, Oct 09, 2017 at 05:51:52PM -0500, Mario Limonciello wrote:
> > +	ret = device_create_file(&wdev->dev, &priv->req_buf_size_attr);
> > +	if (ret)
> > +		goto fail_create_sysfs;
> 
> Why isn't the "WMI core" creating this sysfs file?  Why have per-driver
> sysfs files, making all of the different apis totally different?  It's a
> "common" attribute that they are all going to have to provide, right?
> 
I hadn't really thought about that.  I suppose it's entirely reasonable
to have a way that all WMI ioctls for future drivers will advertise the size
of their expected buffer the same way.

So this does beg a question to others on this distribution who have worked
on WMI drivers- do you know of any WM**/ methods with multiple instances 
that use different buffer sizes, or is it reasonable to expect that the buffer size 
is consistent between instances?

Even in advanced MOF designs I haven't seen it, but this makes me
wonder if an attribute should be created for every instance to be future proof.
(For example $GUID/required_buffer_size/instance0, 
$GUID/required_buffer_size/instance1 etc)

> That way you also don't race with userspace :)
> 
> thanks,
> 
> greg k-h

  reply	other threads:[~2017-10-10 14:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-09 22:51 [PATCH v6 00/14] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 01/14] platform/x86: wmi: Add new method wmidev_evaluate_method Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 02/14] platform/x86: dell-wmi: increase severity of some failures Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 03/14] platform/x86: dell-wmi: clean up wmi descriptor check Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 04/14] platform/x86: dell-wmi: allow 32k return size in the descriptor Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Mario Limonciello
2017-10-10  8:17   ` Pali Rohár
2017-10-10 13:40     ` Mario.Limonciello
2017-10-09 22:51 ` [PATCH v6 06/14] platform/x86: wmi: Don't allow drivers to get each other's GUIDs Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 07/14] platform/x86: dell-smbios: only run if proper oem string is detected Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 08/14] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 09/14] platform/x86: dell-smbios: Introduce dispatcher for SMM calls Mario Limonciello
2017-10-10 16:01   ` Pali Rohár
2017-10-10 19:14     ` Mario.Limonciello
2017-10-12 23:30       ` Darren Hart
2017-10-09 22:51 ` [PATCH v6 10/14] platform/x86: dell-smbios: add filtering capability for requests Mario Limonciello
2017-10-10 18:31   ` Pali Rohár
2017-10-10 20:31     ` Mario.Limonciello
2017-10-09 22:51 ` [PATCH v6 11/14] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver Mario Limonciello
2017-10-12  1:02   ` kbuild test robot
2017-10-09 22:51 ` [PATCH v6 12/14] platform/x86: dell-smbios-smm: test for WSMT Mario Limonciello
2017-10-10 19:11   ` Pali Rohár
2017-10-09 22:51 ` [PATCH v6 13/14] platform/x86: wmi: create character devices when requested by drivers Mario Limonciello
2017-10-10 11:04   ` Greg KH
2017-10-10 11:06   ` Greg KH
2017-10-10 13:41     ` Mario.Limonciello
2017-10-10 13:57       ` Greg KH
2017-10-10 14:00         ` Mario.Limonciello
2017-10-10 19:11   ` Pali Rohár
2017-10-10 19:24     ` Mario.Limonciello
2017-10-11 12:33       ` Alan Cox
2017-10-09 22:51 ` [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface Mario Limonciello
2017-10-10 13:59   ` Greg KH
2017-10-10 14:17     ` Mario.Limonciello [this message]
2017-10-12  1:13   ` kbuild test robot
2017-10-12  1:16   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ea5e28972c5a485f988256de5e4e7289@ausx13mpc120.AMER.DELL.COM \
    --to=mario.limonciello@dell.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=greg@kroah.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mjg59@google.com \
    --cc=pali.rohar@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=quasisec@google.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®