From: <Mario.Limonciello@dell.com>
To: <pali.rohar@gmail.com>
Cc: <dvhart@infradead.org>, <andy.shevchenko@gmail.com>,
<linux-kernel@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>, <luto@kernel.org>,
<quasisec@google.com>, <rjw@rjwysocki.net>, <mjg59@google.com>,
<hch@lst.de>, <greg@kroah.com>
Subject: RE: [PATCH v6 10/14] platform/x86: dell-smbios: add filtering capability for requests
Date: Tue, 10 Oct 2017 20:31:11 +0000 [thread overview]
Message-ID: <6b5cc33ec5f444a58cff4aec90f799ac@ausx13mpc120.AMER.DELL.COM> (raw)
In-Reply-To: <20171010160131.wkaxfsevd6w2akep@pali>
> -----Original Message-----
> From: Pali Rohár [mailto:pali.rohar@gmail.com]
> Sent: Tuesday, October 10, 2017 1:32 PM
> To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> Cc: dvhart@infradead.org; Andy Shevchenko <andy.shevchenko@gmail.com>;
> LKML <linux-kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org;
> Andy Lutomirski <luto@kernel.org>; quasisec@google.com; rjw@rjwysocki.net;
> mjg59@google.com; hch@lst.de; Greg KH <greg@kroah.com>
> Subject: Re: [PATCH v6 10/14] platform/x86: dell-smbios: add filtering capability
> for requests
>
> On Monday 09 October 2017 17:51:48 Mario Limonciello wrote:
> > +static struct token_range token_blacklist[] = {
> > + {0x0000, 0x0175, 0x0176},
> > + {0x0000, 0x0195, 0x0197},
> > + {0x0000, 0x01DC, 0x01DD},
> > + {0x0000, 0x027D, 0x0284},
> > + {0x02E3, 0x0000, 0x0000},
> > + {0x02FF, 0x0000, 0x0000},
> > + {0x0000, 0x0300, 0x0302},
> > + {0x0000, 0x0325, 0x0326},
> > + {0x0000, 0x0332, 0x0335},
> > + {0x0350, 0x0000, 0x0000},
> > + {0x0363, 0x0000, 0x0000},
> > + {0x0368, 0x0000, 0x0000},
> > + {0x0000, 0x03F6, 0x03F7},
> > + {0x0000, 0x049E, 0x049F},
> > + {0x0000, 0x04A0, 0x04A3},
> > + {0x0000, 0x04E6, 0x04E7},
> > + {0x0000, 0x4000, 0x7FFF},
> > + {0x0000, 0x9000, 0x9001},
> > + {0x0000, 0xA000, 0xBFFF},
> > + {0x0000, 0xEFF0, 0xEFFF},
> > +};
>
> Hi! There should be information what is hidden in those tokens, so other
> people would be able to review why are those token blacklisted.
>
I'll add some comments explaining what I can about why they're blacklisted.
Most of them are for use during manufacturing time and those I won't explain further.
next prev parent reply other threads:[~2017-10-10 20:31 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 22:51 [PATCH v6 00/14] Introduce support for Dell SMBIOS over WMI Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 01/14] platform/x86: wmi: Add new method wmidev_evaluate_method Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 02/14] platform/x86: dell-wmi: increase severity of some failures Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 03/14] platform/x86: dell-wmi: clean up wmi descriptor check Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 04/14] platform/x86: dell-wmi: allow 32k return size in the descriptor Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Mario Limonciello
2017-10-10 8:17 ` Pali Rohár
2017-10-10 13:40 ` Mario.Limonciello
2017-10-09 22:51 ` [PATCH v6 06/14] platform/x86: wmi: Don't allow drivers to get each other's GUIDs Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 07/14] platform/x86: dell-smbios: only run if proper oem string is detected Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 08/14] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Mario Limonciello
2017-10-09 22:51 ` [PATCH v6 09/14] platform/x86: dell-smbios: Introduce dispatcher for SMM calls Mario Limonciello
2017-10-10 16:01 ` Pali Rohár
2017-10-10 19:14 ` Mario.Limonciello
2017-10-12 23:30 ` Darren Hart
2017-10-09 22:51 ` [PATCH v6 10/14] platform/x86: dell-smbios: add filtering capability for requests Mario Limonciello
2017-10-10 18:31 ` Pali Rohár
2017-10-10 20:31 ` Mario.Limonciello [this message]
2017-10-09 22:51 ` [PATCH v6 11/14] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver Mario Limonciello
2017-10-12 1:02 ` kbuild test robot
2017-10-09 22:51 ` [PATCH v6 12/14] platform/x86: dell-smbios-smm: test for WSMT Mario Limonciello
2017-10-10 19:11 ` Pali Rohár
2017-10-09 22:51 ` [PATCH v6 13/14] platform/x86: wmi: create character devices when requested by drivers Mario Limonciello
2017-10-10 11:04 ` Greg KH
2017-10-10 11:06 ` Greg KH
2017-10-10 13:41 ` Mario.Limonciello
2017-10-10 13:57 ` Greg KH
2017-10-10 14:00 ` Mario.Limonciello
2017-10-10 19:11 ` Pali Rohár
2017-10-10 19:24 ` Mario.Limonciello
2017-10-11 12:33 ` Alan Cox
2017-10-09 22:51 ` [PATCH v6 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface Mario Limonciello
2017-10-10 13:59 ` Greg KH
2017-10-10 14:17 ` Mario.Limonciello
2017-10-12 1:13 ` kbuild test robot
2017-10-12 1:16 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b5cc33ec5f444a58cff4aec90f799ac@ausx13mpc120.AMER.DELL.COM \
--to=mario.limonciello@dell.com \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=greg@kroah.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mjg59@google.com \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quasisec@google.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®