Re: [Xen-devel] [PATCH v2] xen: Make VPMU init message look less scary

[Juergen Gross <jgross@suse.com>]

On 02/08/16 09:10, Jan Beulich wrote:
>>>> On 02.08.16 at 08:43, <JGross@suse.com> wrote:
>> --- a/arch/x86/xen/pmu.c
>> +++ b/arch/x86/xen/pmu.c
>> @@ -547,8 +547,11 @@ void xen_pmu_init(int cpu)
>>  	return;
>>  
>>  fail:
>> -	pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>> -		cpu, err);
>> +	if (err == -EOPNOTSUPP)
>> +		pr_info_once("VPMU disabled by hypervisor.\n");
>> +	else
>> +		pr_info_once("Could not initialize VPMU for cpu %d, error %d\n",
>> +			cpu, err);
> 
> I'm sorry for not already having thought about this for v1, but
> what about older hypervisors, where the hypercall would return
> -ENOSYS?

I wasn't aware of that possibility. It should be covered, of course!

V3 will be sent soon...

Thanks for noticing now,


Juergen