From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
clm@fb.com, josef@toxicpanda.com, dsterba@suse.com
Cc: linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] btrfs: Fix backref.c selftest compilation warning
Date: Sun, 12 Apr 2020 08:52:08 +0800 [thread overview]
Message-ID: <ea85377e-4648-c174-2827-53173587777c@gmx.com> (raw)
In-Reply-To: <20200411154915.9408-1-tangbin@cmss.chinamobile.com>
[-- Attachment #1.1: Type: text/plain, Size: 1746 bytes --]
On 2020/4/11 下午11:49, Tang Bin wrote:
> Fix missing braces compilation warning in the ARM
> compiler environment:
> fs/btrfs/backref.c: In function ‘is_shared_data_backref’:
> fs/btrfs/backref.c:394:9: warning: missing braces around initializer [-Wmissing-braces]
> struct prelim_ref target = {0};
> fs/btrfs/backref.c:394:9: warning: (near initialization for ‘target.rbnode’) [-Wmissing-braces]
GCC version please.
It looks like you're using an older GCC, as it's pretty common certain
prebuild tool chain is still using outdated GCC.
In my environment with GCC 9.2.0 natively (on aarch64) it's completely fine.
Thus personally I recommend to build your own tool chain using
buildroot, or run it natively, other than rely on prebuilt one.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
> ---
> fs/btrfs/backref.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> index 9c380e7..0cc0257 100644
> --- a/fs/btrfs/backref.c
> +++ b/fs/btrfs/backref.c
> @@ -391,7 +391,7 @@ static int is_shared_data_backref(struct preftrees *preftrees, u64 bytenr)
> struct rb_node **p = &preftrees->direct.root.rb_root.rb_node;
> struct rb_node *parent = NULL;
> struct prelim_ref *ref = NULL;
> - struct prelim_ref target = {0};
> + struct prelim_ref target = {};
In fact your fix could cause problem, as the original code is
initializing all members to 0, but now it's uninitialized.
You need to locate the root cause other than blindly follow the warning.
Thanks,
Qu
> int result;
>
> target.parent = bytenr;
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-04-12 0:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 15:49 Tang Bin
2020-04-12 0:52 ` Qu Wenruo [this message]
2020-04-12 3:21 ` Tang Bin
2020-04-12 5:04 ` Qu Wenruo
2020-04-14 15:19 ` David Sterba
2020-04-14 15:22 ` David Sterba
2020-04-15 1:22 ` Tang Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea85377e-4648-c174-2827-53173587777c@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®