From: Tang Bin <tangbin@cmss.chinamobile.com>
To: dsterba@suse.cz, clm@fb.com, josef@toxicpanda.com,
dsterba@suse.com, linux-btrfs@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Subject: Re: [PATCH] btrfs: Fix backref.c selftest compilation warning
Date: Wed, 15 Apr 2020 09:22:28 +0800 [thread overview]
Message-ID: <f292429f-6b4e-4b2e-db5a-9bf02a3cde0e@cmss.chinamobile.com> (raw)
In-Reply-To: <20200414152233.GV5920@twin.jikos.cz>
Hi David:
On 2020/4/14 23:22, David Sterba wrote:
> On Tue, Apr 14, 2020 at 05:19:31PM +0200, David Sterba wrote:
>> On Sat, Apr 11, 2020 at 11:49:15PM +0800, Tang Bin wrote:
>>> Fix missing braces compilation warning in the ARM
>>> compiler environment:
>>> fs/btrfs/backref.c: In function ‘is_shared_data_backref’:
>>> fs/btrfs/backref.c:394:9: warning: missing braces around initializer [-Wmissing-braces]
>>> struct prelim_ref target = {0};
>>> fs/btrfs/backref.c:394:9: warning: (near initialization for ‘target.rbnode’) [-Wmissing-braces]
>>>
>>> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
>>> Signed-off-by: Shengju Zhang <zhangshengju@cmss.chinamobile.com>
>>> ---
>>> fs/btrfs/backref.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
>>> index 9c380e7..0cc0257 100644
>>> --- a/fs/btrfs/backref.c
>>> +++ b/fs/btrfs/backref.c
>>> @@ -391,7 +391,7 @@ static int is_shared_data_backref(struct preftrees *preftrees, u64 bytenr)
>>> struct rb_node **p = &preftrees->direct.root.rb_root.rb_node;
>>> struct rb_node *parent = NULL;
>>> struct prelim_ref *ref = NULL;
>>> - struct prelim_ref target = {0};
>>> + struct prelim_ref target = {};
>> I wonder why this initialization is a problem while there are about 20
>> other uses of "{0}". The warning is about the embedded rbnode, but why
>> does a more recent compiler not warn about that? Is this a missing fix
>> from the one you use?
>>
>> I don't mind fixing compiler warnings as long as it bothers enough
>> people, eg. we have fixes reported by gcc 7 but I'm hesitant to fix
>> anything older without a good reason.
> This seems to be the bug report
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53119
> "Bug 53119 - -Wmissing-braces wrongly warns about universal zero
> initializer {0} "
Thank you for your reply. My tool chain is
"arm-linux-gnueabihf-gcc(Linaro GCC 4.9-2017.01) 4.9.4".
I was trying to do an experiment on the hardware so I compiled it and
there was a warning. Maybe as Qu Wenruo said possible tools are old?
Thank you for your patience,
Tang Bin
prev parent reply other threads:[~2020-04-15 1:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 15:49 Tang Bin
2020-04-12 0:52 ` Qu Wenruo
2020-04-12 3:21 ` Tang Bin
2020-04-12 5:04 ` Qu Wenruo
2020-04-14 15:19 ` David Sterba
2020-04-14 15:22 ` David Sterba
2020-04-15 1:22 ` Tang Bin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f292429f-6b4e-4b2e-db5a-9bf02a3cde0e@cmss.chinamobile.com \
--to=tangbin@cmss.chinamobile.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®