From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Hermes Zhang <chenhuiz@axis.com>,
jic23@kernel.org, krzysztof.kozlowski+dt@linaro.org,
robh+dt@kernel.org,
Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@axis.com, Lars-Peter Clausen <lars@metafoo.de>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050
Date: Thu, 4 May 2023 12:49:39 +0200 [thread overview]
Message-ID: <ea8c85e1-3bc1-14ce-90d4-27915bcef631@linaro.org> (raw)
In-Reply-To: <20230504091421.2054451-3-chenhuiz@axis.com>
On 04/05/2023 11:14, Hermes Zhang wrote:
> ICM-20600 is almost same as ICM-20602 which already support in mpu6050
> driver. Specify "invensense,icm20602" as a fallback compatible
>
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
> ---
>
> Notes:
> v2: require specifying "invensense,icm20602" as a fallback compatible
> in the binding, as suggested
>
> .../devicetree/bindings/iio/imu/invensense,mpu6050.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> index ec64d7877fe5..711a1beeaecf 100644
> --- a/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> +++ b/Documentation/devicetree/bindings/iio/imu/invensense,mpu6050.yaml
> @@ -33,6 +33,9 @@ properties:
> - items:
> - const: invensense,icm20608d
> - const: invensense,icm20608
> + - items:
> + - const: invensense,icm20600
> + - const: invensense,icm20602
Don't stuff entries at the end. This should be rather before above
icm20608 entry.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
prev parent reply other threads:[~2023-05-04 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 9:14 [PATCH v2 0/2] Add support for the ICM 20600 IMU Hermes Zhang
2023-05-04 9:14 ` [PATCH v2 1/2] iio: imu: mpu6050: " Hermes Zhang
2023-05-04 9:14 ` [PATCH v2 2/2] dt-bindings: iio: imu: mpu6050: Add icm20600 bindings to mpu6050 Hermes Zhang
2023-05-04 10:49 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea8c85e1-3bc1-14ce-90d4-27915bcef631@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chenhuiz@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=jmaneyrol@invensense.com \
--cc=kernel@axis.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®