From: Guenter Roeck <linux@roeck-us.net>
To: Jonas Rebmann <jre@pengutronix.de>,
Jean Delvare <jdelvare@suse.com>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 2/4] hwmon: ina238: Add label support for voltage inputs
Date: Wed, 16 Jul 2025 08:04:16 -0700 [thread overview]
Message-ID: <eaa183cc-a56f-4a33-bf01-a5279799f395@roeck-us.net> (raw)
In-Reply-To: <20250715-ina228-v1-2-3302fae4434b@pengutronix.de>
On 7/15/25 13:49, Jonas Rebmann wrote:
> The INA family of power monitors estimate power consumption based on
> two voltage measurements: across a shunt resistor and across the bus.
>
> Conveniently label them "Shunt Voltage" and "Bus Voltage".
>
Labels are supposed to show the sensor's association with the system, not
the chip labeling. So this is a no-go. And, yes, apparently I have been too
complacent with people (mis-)using the label attributes. That doesn't make
it better, so don't use it as argument to support this one.
Guenter
next prev parent reply other threads:[~2025-07-16 15:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-15 20:48 [PATCH 0/4] ina238: Improvements and INA228 support Jonas Rebmann
2025-07-15 20:49 ` [PATCH 1/4] hwmon: ina238: Fix inconsistent whitespace Jonas Rebmann
2025-07-16 15:52 ` Guenter Roeck
2025-07-15 20:49 ` [PATCH 2/4] hwmon: ina238: Add label support for voltage inputs Jonas Rebmann
2025-07-16 15:04 ` Guenter Roeck [this message]
2025-07-17 7:30 ` Jonas Rebmann
2025-07-17 15:24 ` Guenter Roeck
2025-07-15 20:49 ` [PATCH 3/4] dt-bindings: Add INA228 to ina2xx devicetree bindings Jonas Rebmann
2025-07-16 6:30 ` Krzysztof Kozlowski
2025-07-15 20:49 ` [PATCH 4/4] hwmon: ina238: Add support for INA228 Jonas Rebmann
2025-07-16 15:50 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eaa183cc-a56f-4a33-bf01-a5279799f395@roeck-us.net \
--to=linux@roeck-us.net \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=jre@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®