mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Indan Zupancic" <indan@nul.nu>
To: "Andrew Lutomirski" <luto@mit.edu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	"Will Drewry" <wad@chromium.org>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-doc@vger.kernel.org, kernel-hardening@lists.openwall.com,
	netdev@vger.kernel.org, x86@kernel.org, arnd@arndb.de,
	davem@davemloft.net, mingo@redhat.com, oleg@redhat.com,
	peterz@infradead.org, rdunlap@xenotime.net,
	mcgrathr@chromium.org, tglx@linutronix.de, eparis@redhat.com,
	serge.hallyn@canonical.com, djm@mindrot.org,
	scarybeasts@gmail.com, pmoore@redhat.com,
	akpm@linux-foundation.org, corbet@lwn.net,
	eric.dumazet@gmail.com, markus@chromium.org,
	keescook@chromium.org
Subject: Re: [PATCH v8 3/8] seccomp: add system call filtering using BPF
Date: Fri, 17 Feb 2012 02:25:55 +0100	[thread overview]
Message-ID: <eab10cc7834be3c720147a6b24769840.squirrel@webmail.greenhost.nl> (raw)
In-Reply-To: <CAObL_7G7CvCVgjR-JYjNDi_Sy65UHXaqas4-sQCVej-4bX2PJA@mail.gmail.com>

On Fri, February 17, 2012 01:51, Andrew Lutomirski wrote:
> IMO the best solution is to have the One True Seccomp Filter Compiler
> (tm).  It would handle multiple namespaces, cross-arch differences,
> and such, and it would do it correctly.  It could live in the kernel
> tree.

I'm not interested in any such compiler, if I use this BPF thing I'll use
it directly by scanning my syscall table info and converting it to a BPF
filter for the cases where it's possible. This code will be cross-platform,
all the platform dependent info comes from the syscall table.

It seems I'll just build a bitmask telling what to do for each syscall,
with special cases for the few syscalls that can be handled totally within
BPF by checking the arguments.

My total lines of code is 5k now, I'm not going to use a complex thousands
of lines, badly tested, probably buggy compiler just for BPF support.

> Without something like that or an incredible amount of special care,
> actual portability is probably a pipe dream.

The filter programs are already platform dependent because of the syscall
numbers and sometimes args differences. But that is no reason to make it
even less cross-platform.

Your OTSF compiler won't be able to handle different modes other than
adding a check at the start and having totally orthogonal codes for the
different cases. You can as well have separate filters then. Any other
approach dies because of the added complexity or will be a lot slower.

Greetings,

Indan



  parent reply	other threads:[~2012-02-17  1:26 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-16 20:02 [PATCH v8 1/8] sk_run_filter: add support for custom load_pointer Will Drewry
2012-02-16 20:02 ` [PATCH v8 2/8] seccomp: kill the seccomp_t typedef Will Drewry
2012-02-20  2:55   ` James Morris
2012-02-16 20:02 ` [PATCH v8 3/8] seccomp: add system call filtering using BPF Will Drewry
2012-02-16 20:06   ` H. Peter Anvin
2012-02-16 20:25     ` Will Drewry
2012-02-16 21:17       ` H. Peter Anvin
2012-02-16 21:28         ` Markus Gutschke
2012-02-16 21:34           ` H. Peter Anvin
2012-02-16 21:51             ` Will Drewry
2012-02-16 22:06               ` H. Peter Anvin
2012-02-16 23:00                 ` Will Drewry
2012-02-17  0:23                   ` Andrew Lutomirski
2012-02-17  0:43                   ` H. Peter Anvin
2012-02-17  0:50                   ` Eric Paris
2012-02-17  2:24                     ` H. Peter Anvin
2012-02-17  3:53                     ` Will Drewry
2012-02-17  4:12                       ` H. Peter Anvin
2012-02-17  4:26                         ` Will Drewry
2012-02-17  4:32                           ` H. Peter Anvin
2012-02-17  4:40                             ` Will Drewry
2012-02-16 21:31         ` Will Drewry
2012-02-17  0:48         ` Indan Zupancic
2012-02-17  0:51           ` Andrew Lutomirski
2012-02-17  1:10             ` H. Peter Anvin
2012-02-17  1:25             ` Indan Zupancic [this message]
2012-02-17  1:33           ` H. Peter Anvin
2012-02-17  2:00             ` Indan Zupancic
2012-02-17  2:16               ` Andrew Lutomirski
2012-02-17  2:22                 ` H. Peter Anvin
2012-02-17  3:27                   ` Indan Zupancic
2012-02-17  4:09                     ` H. Peter Anvin
2012-02-17  4:51                       ` Indan Zupancic
2012-02-17  2:44   ` Indan Zupancic
2012-02-17  3:38     ` [kernel-hardening] " Will Drewry
2012-02-16 20:02 ` [PATCH v8 4/8] seccomp: add SECCOMP_RET_ERRNO Will Drewry
2012-02-16 20:02 ` [PATCH v8 5/8] seccomp: Add SECCOMP_RET_TRAP Will Drewry
     [not found]   ` <CAE6n16mCrJC=Sre+PT1H_VfSjW0MGyi0xtEcdcRvGMvvwXWzmA@mail.gmail.com>
2012-02-16 20:28     ` Markus Gutschke
2012-02-16 21:23       ` H. Peter Anvin
2012-02-16 20:42     ` Will Drewry
2012-02-16 21:11       ` [PATCH v9 " Will Drewry
2012-02-16 21:11         ` [PATCH v9 8/8] Documentation: prctl/seccomp_filter Will Drewry
2012-02-16 21:28       ` [PATCH v8 5/8] seccomp: Add SECCOMP_RET_TRAP H. Peter Anvin
2012-02-16 21:33         ` Will Drewry
2012-02-16 20:02 ` [PATCH v8 6/8] ptrace,seccomp: Add PTRACE_SECCOMP support Will Drewry
2012-02-17  5:08   ` Indan Zupancic
2012-02-17 16:23     ` Will Drewry
2012-02-17 22:55       ` Indan Zupancic
2012-02-21 17:31         ` Will Drewry
2012-02-16 20:02 ` [PATCH v8 7/8] x86: Enable HAVE_ARCH_SECCOMP_FILTER Will Drewry
2012-02-16 20:02 ` [PATCH v8 8/8] Documentation: prctl/seccomp_filter Will Drewry
2012-02-16 20:08 ` [PATCH v8 1/8] sk_run_filter: add support for custom load_pointer Will Drewry
2012-02-17  1:54 ` Joe Perches
2012-02-17  2:22   ` Will Drewry
2012-02-17  3:04 ` Indan Zupancic
2012-02-17  4:13   ` Will Drewry
2012-02-17  5:05     ` Indan Zupancic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eab10cc7834be3c720147a6b24769840.squirrel@webmail.greenhost.nl \
    --to=indan@nul.nu \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=djm@mindrot.org \
    --cc=eparis@redhat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@mit.edu \
    --cc=markus@chromium.org \
    --cc=mcgrathr@chromium.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pmoore@redhat.com \
    --cc=rdunlap@xenotime.net \
    --cc=scarybeasts@gmail.com \
    --cc=serge.hallyn@canonical.com \
    --cc=tglx@linutronix.de \
    --cc=wad@chromium.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®