From: David Heidelberg <david@ixit.cz>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Robert Foss <rfoss@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sdm845-db845c: Use pad fn instead of defining own
Date: Mon, 22 Dec 2025 15:01:23 +0100 [thread overview]
Message-ID: <eabea4d4-366c-491a-bdcf-cbbfede66bd1@ixit.cz> (raw)
In-Reply-To: <f86b483d-c674-4901-b2c8-19a535df4234@oss.qualcomm.com>
On 18/12/2025 13:25, Konrad Dybcio wrote:
> On 12/17/25 12:39 PM, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> Instead of defining own pad function for master clock, pick one offered
>> by sdm845 device-tree include.
>
> I'm a little bitter about the wording - the pad function here is "cam_mclk",
> whereas what you're doing is inheriting a common pinmux/pincfg node that
> refers to that function
>
> [...]
>
>> - mclk0-pins {
>> - pins = "gpio13";
>> - function = "cam_mclk";
>> -
>> - drive-strength = <16>;
>
> This patch changes the drive-strength (16 -> 2 mA)
>
> FWIW it's 2 on reference designs and Sony boards, check your
> downstream kernel
I don't have any. I'm fine with this patch not getting applied, but I'll
CC Robert who added the support, maybe he can verify.
David
>
> Konrad
--
David Heidelberg
next prev parent reply other threads:[~2025-12-22 14:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 11:39 [PATCH v2 0/2] Commonize pinctrl for camera master clock on Qualcomm SDM845 David Heidelberg via B4 Relay
2025-12-17 11:39 ` [PATCH v2 1/2] arm64: dts: qcom: sdm845: Introduce camera master clock pinctrl David Heidelberg via B4 Relay
2025-12-17 11:43 ` Konrad Dybcio
2025-12-17 11:39 ` [PATCH v2 2/2] arm64: dts: qcom: sdm845-db845c: Use pad fn instead of defining own David Heidelberg via B4 Relay
2025-12-18 12:25 ` Konrad Dybcio
2025-12-22 14:01 ` David Heidelberg [this message]
2025-12-29 12:59 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eabea4d4-366c-491a-bdcf-cbbfede66bd1@ixit.cz \
--to=david@ixit.cz \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®