From: Javen <javen_xu@realsil.com.cn>
To: Daniel Golle <daniel@makrotopia.org>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
顾晓军 <freddy_gu@realsil.com.cn>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"vladimir.oltean@nxp.com" <vladimir.oltean@nxp.com>,
"Balázs Triszka" <info@balika011.hu>
Subject: RE: [PATCH net-next v1 2/2] net: phy: realtek: load firmware for RTL8261C
Date: Mon, 1 Jun 2026 05:38:54 +0000 [thread overview]
Message-ID: <ead2cd49c1394c01a404da8e3962ad79@realsil.com.cn> (raw)
In-Reply-To: <ahgy9Cce9MmY6KLl@makrotopia.org>
>On Thu, May 28, 2026 at 03:52:26PM +0800, javen wrote:
>> From: Javen Xu <javen_xu@realsil.com.cn>
>>
>> This patch adds support for loading firmware. Download some parameters
>> for RTL8261C.
>
>I'd like to bring to your attention that the OpenWrt community has
>impemented a more complete support for initial register patching using a
>extremely similar firmware format.
>
>https://github.com/openwrt/openwrt/blob/main/target/linux/generic/pendi
>ng-6.18/742-net-phy-realtek-add-5G-and-10G-PHY-support.patch
>
>We used 'RTK_PATCH_OP_*' while this series uses only 'OP_*' as macro
>names defining the initval patching operations.
>
>As the vendor downstream driver had the operations hard-coded in tables
>our community came up with a tool to generate the patching blobs from the
>GPL-licensed vendor driver:
>
>https://github.com/balika011/realtek_phy_firmware
>
>Given the similarity I wonder if this code has been taken from Balázs Triszka
>work (which clearly predates it) without giving him the due credit.
Thank you for bringing this to my attention and sharing the links to the OpenWrt community's and Balázs Triszka's work.
I have reviewed the repository and the patch you mentioned. I want to clarify that our code was developed independently. Since both implementations are tackling the exact same hardware requirements for Realtek PHYs, the fundamental hardware operations―such as read, write, mask, and delay―are strictly defined by the hardware. In this patch, we only kept some of the operations that are used, such as op_poll.
I hope this clears up the misunderstanding.
BRs,
Javen
next prev parent reply other threads:[~2026-06-01 5:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 7:52 [PATCH net-next v1 0/2] Add support for RTL8261c javen
2026-05-28 7:52 ` [PATCH net-next v1 1/2] net: phy: realtek: add support for RTL8261 javen
2026-05-28 9:37 ` Nicolai Buchwitz
2026-05-29 0:51 ` Andrew Lunn
2026-06-03 2:35 ` Javen
2026-05-28 12:39 ` Andrew Lunn
2026-05-28 12:42 ` Andrew Lunn
2026-05-28 16:56 ` Aleksander Jan Bajkowski
2026-05-28 7:52 ` [PATCH net-next v1 2/2] net: phy: realtek: load firmware for RTL8261C javen
2026-05-28 9:08 ` Nicolai Buchwitz
2026-05-28 12:20 ` Daniel Golle
2026-06-01 5:38 ` Javen [this message]
2026-05-29 1:01 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ead2cd49c1394c01a404da8e3962ad79@realsil.com.cn \
--to=javen_xu@realsil.com.cn \
--cc=andrew@lunn.ch \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=freddy_gu@realsil.com.cn \
--cc=hkallweit1@gmail.com \
--cc=info@balika011.hu \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®