* [PATCH] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c
@ 2024-12-13 16:38 Lizhi Hou
2024-12-13 17:05 ` Jeffrey Hugo
2024-12-13 17:11 ` Jeffrey Hugo
0 siblings, 2 replies; 3+ messages in thread
From: Lizhi Hou @ 2024-12-13 16:38 UTC (permalink / raw)
To: ogabbay, quic_jhugo, dri-devel, mike
Cc: linux-kernel, min.ma, max.zhen, sonal.santan, king.tam,
mario.limonciello, Lizhi Hou
From: Mike Lothian <mike@fireburn.co.uk>
For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by
trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will
fail.
Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
Reported-by: Mike Lothian <mike@fireburn.co.uk>
Closes: https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohaNzXxE7WD2cj9kFJERQ@mail.gmail.com/
Signed-off-by: Mike Lothian <mike@fireburn.co.uk>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
drivers/accel/amdxdna/amdxdna_mailbox.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/accel/amdxdna/amdxdna_mailbox.c b/drivers/accel/amdxdna/amdxdna_mailbox.c
index fe684f463b94..79b9801935e7 100644
--- a/drivers/accel/amdxdna/amdxdna_mailbox.c
+++ b/drivers/accel/amdxdna/amdxdna_mailbox.c
@@ -6,6 +6,7 @@
#include <drm/drm_device.h>
#include <drm/drm_managed.h>
#include <linux/bitfield.h>
+#include <linux/interrupt.h>
#include <linux/iopoll.h>
#define CREATE_TRACE_POINTS
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c
2024-12-13 16:38 [PATCH] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c Lizhi Hou
@ 2024-12-13 17:05 ` Jeffrey Hugo
2024-12-13 17:11 ` Jeffrey Hugo
1 sibling, 0 replies; 3+ messages in thread
From: Jeffrey Hugo @ 2024-12-13 17:05 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, dri-devel, mike
Cc: linux-kernel, min.ma, max.zhen, sonal.santan, king.tam,
mario.limonciello
On 12/13/2024 9:38 AM, Lizhi Hou wrote:
> From: Mike Lothian <mike@fireburn.co.uk>
>
> For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by
> trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will
> fail.
>
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Reported-by: Mike Lothian <mike@fireburn.co.uk>
> Closes: https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohaNzXxE7WD2cj9kFJERQ@mail.gmail.com/
> Signed-off-by: Mike Lothian <mike@fireburn.co.uk>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Pushed to drm-misc-next
-Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c
2024-12-13 16:38 [PATCH] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c Lizhi Hou
2024-12-13 17:05 ` Jeffrey Hugo
@ 2024-12-13 17:11 ` Jeffrey Hugo
1 sibling, 0 replies; 3+ messages in thread
From: Jeffrey Hugo @ 2024-12-13 17:11 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, dri-devel, mike
Cc: linux-kernel, min.ma, max.zhen, sonal.santan, king.tam,
mario.limonciello
On 12/13/2024 9:38 AM, Lizhi Hou wrote:
> From: Mike Lothian <mike@fireburn.co.uk>
>
> For amdxdna_mailbox.c, linux/interrupt.h is indirectly included by
> trace/events/amdxdna.h. So if TRACING is disabled, driver compiling will
> fail.
>
> Fixes: b87f920b9344 ("accel/amdxdna: Support hardware mailbox")
> Reported-by: Mike Lothian <mike@fireburn.co.uk>
> Closes: https://lore.kernel.org/dri-devel/CAHbf0-E+Z2O7rW-x+-EKNQ-nLbf=_ohaNzXxE7WD2cj9kFJERQ@mail.gmail.com/
> Signed-off-by: Mike Lothian <mike@fireburn.co.uk>
> Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Applied to drm-misc-next
-Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-13 17:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-12-13 16:38 [PATCH] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c Lizhi Hou
2024-12-13 17:05 ` Jeffrey Hugo
2024-12-13 17:11 ` Jeffrey Hugo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®