From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>,
Sebastian Reichel <sre@kernel.org>,
linux-pm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Dirk Brandewie <dirk.brandewie@gmail.com>,
kernel@puri.sm, stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] power: supply: max17042_battery: Prevent int underflow in set_soc_threshold
Date: Thu, 16 Sep 2021 12:26:35 +0200 [thread overview]
Message-ID: <eb0d1829-2379-c0ee-4043-70c86203286d@canonical.com> (raw)
In-Reply-To: <20210914121806.1301131-2-sebastian.krzyszkowiak@puri.sm>
On 14/09/2021 14:18, Sebastian Krzyszkowiak wrote:
> max17042_set_soc_threshold gets called with offset set to 1, which means
> that minimum threshold value would underflow once SOC got down to 0,
> causing invalid alerts from the gauge.
>
> Fixes: e5f3872d2044 ("max17042: Add support for signalling change in SOC")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
> ---
> v2: added commit description
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2021-09-16 10:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 12:18 [PATCH v2 1/2] power: supply: max17042_battery: Clear status bits in interrupt handler Sebastian Krzyszkowiak
2021-09-14 12:18 ` [PATCH v2 2/2] power: supply: max17042_battery: Prevent int underflow in set_soc_threshold Sebastian Krzyszkowiak
2021-09-16 10:26 ` Krzysztof Kozlowski [this message]
2021-09-16 10:26 ` [PATCH v2 1/2] power: supply: max17042_battery: Clear status bits in interrupt handler Krzysztof Kozlowski
2021-10-11 3:32 ` Sebastian Krzyszkowiak
2021-10-12 16:01 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb0d1829-2379-c0ee-4043-70c86203286d@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=dirk.brandewie@gmail.com \
--cc=kernel@puri.sm \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sebastian.krzyszkowiak@puri.sm \
--cc=sre@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®